Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin dependency constants #458

Merged
merged 12 commits into from
Dec 14, 2023
Merged

Add plugin dependency constants #458

merged 12 commits into from
Dec 14, 2023

Conversation

catornot
Copy link
Member

Adds dependency constants for plugins so mods can rely on plugins without always producing script errors when the plugin is missing

testing

If you trust me :)
test plugin : rrplug_test.zip
test mod : cat_or_not.ProximityChat.zip

expected result : no compile errors and a message on CLIENT load "we have RRPLUG_TEST" with the plugin

@pg9182 pg9182 self-requested a review April 26, 2023 02:15
pg9182
pg9182 approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@pg9182 pg9182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the sample mod/plugin, seems to work as intended. Code looks good.

@ASpoonPlaysGames ASpoonPlaysGames added merge conflicts Blocked by merge conflicts, waiting on the author to resolve almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Sep 2, 2023
@ASpoonPlaysGames
Copy link
Contributor

@catornot Merge conflicts :)

@catornot catornot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Sep 12, 2023
@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Nov 20, 2023
ASpoonPlaysGames
ASpoonPlaysGames requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any code that handles characters in the plugin name that aren't valid for squirrel constants.

Things like spaces and special characters should get handled, or the squirrel constants might become unusable

@catornot
Copy link
Member Author

I don't see any code that handles characters in the plugin name that aren't valid for squirrel constants.

I was thinking that the plugin creator would be responsible for that but I guess I could add a warning.

ASpoonPlaysGames
ASpoonPlaysGames approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, requested change was implemented

@GeckoEidechse
Copy link
Member

Merging based on reviews

@GeckoEidechse GeckoEidechse merged commit 43f0bce into R2Northstar:main Dec 14, 2023
2 checks passed
@catornot catornot deleted the plugin-dependency-constants branch January 21, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASpoonPlaysGames ASpoonPlaysGames ASpoonPlaysGames approved these changes

@pg9182 pg9182 pg9182 approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@catornot @ASpoonPlaysGames @GeckoEidechse @pg9182 @Alystrasz