Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/client: Remove uses of Autohook from scriptbrowserhooks.cpp #833

Merged
merged 2 commits into from
Dec 15, 2024
Merged

scripts/client: Remove uses of Autohook from scriptbrowserhooks.cpp #833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a42c452
scripts/client: Manually hook OpenExternalWebBrowser
ASpoonPlaysGames Dec 15, 2024
a777b3b
scripts/client: Remove AUTOHOOK_INIT and AUTOHOOK_DISPATCH
ASpoonPlaysGames Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions primedev/scripts/client/scriptbrowserhooks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,22 @@

AUTOHOOK_INIT()

bool* bIsOriginOverlayEnabled;

// clang-format off
AUTOHOOK(OpenExternalWebBrowser, engine.dll + 0x184E40,
void, __fastcall, (char* pUrl, char flags))
// clang-format on
static void(__fastcall* o_pOpenExternalWebBrowser)(char* pUrl, char flags) = nullptr;
static void __fastcall h_OpenExternalWebBrowser(char* pUrl, char flags)
{
bool bIsOriginOverlayEnabledOriginal = *bIsOriginOverlayEnabled;
bool isHttp = !strncmp(pUrl, "http://", 7) || !strncmp(pUrl, "https://", 8);
if (flags & 2 && isHttp) // custom force external browser flag
*bIsOriginOverlayEnabled = false; // if this bool is false, game will use an external browser rather than the origin overlay one

OpenExternalWebBrowser(pUrl, flags);
o_pOpenExternalWebBrowser(pUrl, flags);
*bIsOriginOverlayEnabled = bIsOriginOverlayEnabledOriginal;
}

ON_DLL_LOAD_CLIENT("engine.dll", ScriptExternalBrowserHooks, (CModule module))
{
AUTOHOOK_DISPATCH()
o_pOpenExternalWebBrowser = module.Offset(0x184E40).RCast<decltype(o_pOpenExternalWebBrowser)>();
HookAttach(&(PVOID&)o_pOpenExternalWebBrowser, (PVOID)h_OpenExternalWebBrowser);

bIsOriginOverlayEnabled = module.Offset(0x13978255).RCast<bool*>();
}
Loading