Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cheat flag from cl_gib_lifetime #837

Merged
merged 6 commits into from
Feb 1, 2025

Conversation

NachosChipeados
Copy link
Contributor

There is literally 0 reason for it to have it, especially because its ragdoll counterparts cl_ragdoll_force_fade_time_ don't. No idea what Respawn was thinking to be honest

Titanfall.2.2025-01-18.13-55-53.mp4

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jan 18, 2025
@GeckoEidechse GeckoEidechse requested a review from Zanieon January 18, 2025 22:04
Copy link
Member

@catornot catornot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs any testing just a simple convar change

@catornot catornot added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jan 21, 2025
Copy link

@Zanieon Zanieon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tempted to just say a LGTM, because this is one of those simple PRs.

@Alystrasz Alystrasz merged commit 72acef9 into R2Northstar:main Feb 1, 2025
4 checks passed
@NachosChipeados NachosChipeados deleted the gib_lifetime_patch branch February 1, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants