Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in .py example files #109

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Bug fix in .py example files #109

merged 1 commit into from
Feb 8, 2024

Conversation

Bachibouzouk
Copy link
Collaborator

@Bachibouzouk Bachibouzouk commented Dec 14, 2023

Closes #107

@Bachibouzouk
Copy link
Collaborator Author

I suggest we also wait until the review of joss to make a new release, what do you think @Stevogallo @FLomb @mohammadamint ?

@FLomb FLomb self-assigned this Feb 6, 2024
@FLomb
Copy link
Contributor

FLomb commented Feb 6, 2024

Hi @Bachibouzouk, I'd like to merge this PR, but it's still in the 'draft' stage. Why so? If we speed up this PR, we may manage to release v0.5.1 sooner than the start of the JOSS review (which is likely starting soon, since an editor has been assigned).

@Bachibouzouk Bachibouzouk marked this pull request as ready for review February 7, 2024 09:32
Copy link
Contributor

@FLomb FLomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are very minor; I agree with them and have no comments.

@FLomb FLomb merged commit 9c9f78d into main Feb 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in cloud plot generation from terminal
2 participants