Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/empty peak time range #132

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix/empty peak time range #132

merged 1 commit into from
Apr 25, 2024

Conversation

JW-Kraft
Copy link
Collaborator

Implemented the fix as discussed in issue #80.
rand_peak_enlarge is always rounded to at least 1 to avoid the empty peak_time_range error.

@JW-Kraft JW-Kraft requested a review from FLomb April 16, 2024 13:25
@JW-Kraft JW-Kraft self-assigned this Apr 16, 2024
@Bachibouzouk
Copy link
Collaborator

It seems from the commits that you created the commit form another branch than main. Usually we work from development and merge into main only after releases

@JW-Kraft JW-Kraft changed the base branch from main to development April 16, 2024 15:00
@JW-Kraft
Copy link
Collaborator Author

Yes, I created it from development. Sorry, just selected the wrong base for this PR.

@FLomb FLomb added the bug Something isn't working label Apr 25, 2024
FLomb
FLomb approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@FLomb FLomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed change looks good to me. And it's a minor change, so I'm happy to approve it without further ado.

@FLomb FLomb merged commit 96c987d into development Apr 25, 2024
1 check passed
@Bachibouzouk Bachibouzouk deleted the fix/empty_peak_time_range branch April 29, 2024 12:25
@Bachibouzouk Bachibouzouk mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FLomb FLomb FLomb approved these changes

Assignees

@JW-Kraft JW-Kraft

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JW-Kraft @Bachibouzouk @FLomb