Fix duty cycle selection #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Bachibouzouk
commented
Jun 5, 2024
| or self.cw12[0] <= evaluate < self.cw12[1] | ||
| ): | ||
| if range_within_window( | ||
| indexes_low, indexes_high, self.cw11 |
FLomb
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Thanks, @Bachibouzouk, for this PR. I agree with your proposed solution, which I have tested with positive outcomes locally.
Previously the mean of the index range was computed and see if it was falling within a duty cycle. This method compare the boundaries of the range with the one of each duty cycle to know if there is an intersection. If there is one, the duty cycle is chosen. Note: this method does not take into account the case where the indexes range spans accross more than one duty cycle.
Bachibouzouk
force-pushed
the
fix/duty_cycle_selection
branch
from
2db0f82 to
2ea6532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged prior to merging #152
This PR is designed to be read commit by commit, the explanations are in the commit messages