Alternative backward compatibility approach for user code #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthegeek
reviewed
Sep 12, 2023
t-kalinowski
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
This is a very nice approach. Some pros:
- It doesn't expand the exported API footprint
- It doesn't increase the new-user learning burden nor require any extra work from users
- Improving over the previous hack, it works even if S7 is not attached.
- No deprecation notices will be required once this backwards compatibility hack will no longer be necessary; it will just fade away naturally with time.
Very nice!
DavisVaughan
approved these changes
Sep 13, 2023
|
No concerns in WG call 2023-10-16 |
#Conflicts: # R/zzz.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326