Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label language priority order #105

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

jamiefeiss
Copy link
Collaborator

Labels are now set in order of language priority in the following order:

  1. @en
  2. @en-* (e.g. @en-us, @en-gb, etc.)
  3. no language tag
  4. Other language tags

Resolves #103.

Copy link
Collaborator

@hjohns hjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good for correcting the immediate multiple lang scenario, but might need a follow up issue to drive the default languages from a config, and determine how browser default lang might be used.

Copy link
Collaborator

@edmondchuc edmondchuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with multilingual vocab from GSQ at https://gsq-prez.dev.kurrawong.ai/v/vocab/tmscl:skos-demo.

Looks good.

@jamiefeiss jamiefeiss merged commit d71362f into main Sep 11, 2023
1 check passed
@jamiefeiss jamiefeiss deleted the feature/label-language-fix branch September 11, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language tag prioritisation
3 participants