This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Android demo compile fixes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for fixing! That was strange the issue was not found out by the CI; will check once again why |
|
Thank you! That's strange that the build issue was not found by CI; will check why |
dr-orlovsky
approved these changes
Jan 19, 2021
|
@dr-orlovsky this doesn't completely solve the issue though, it only gets the app to build. I still get this crash report mentioned at the bottom of this issue: #47 |
|
Yes, looking into that. Can I merge this PR? (I will do another one for the second half of the issue) |
|
Thanks! Sure go for it. |
dr-orlovsky
added a commit
that referenced
this pull request
Jan 21, 2021
This reverts commit b683ace.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.