pkg/uwb-dw1000: add patch for rf_txctrl value #17724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjmolinas
added
the
CI: ready for build
|
@rdagher might be interested |
aabadie
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
I confirm that Table 38 in the user manual (you link points to 2.11) says that it should be 0x001E3FE0 but in 2.18 (https://www.decawave.com/dw1000/usermanual/) it should be 0x001E3FE3.
ACK
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds a patch for Decawave/uwb-dw1000#2, if this is merged upstream I'll remove the patch.
Testing procedure
Just checking the reference manual value is enough, see Table 38: Sub-Register 0x28:0C– RF_TXCTRL values in https://www.decawave.com/sites/default/files/resources/dw1000_user_manual_2.11.pdf
Issues/PRs references
Decawave/uwb-dw1000#2
PR fixing issue: Decawave/uwb-dw1000#4