Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutils: Avoid deprecated parameter #302

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 31, 2024

The login_or_token parameter of the Github class is deprecated. See also here. To prevent future surprises, let's port over to the recommended alternative, before it gets dropped.

Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Tested with current RC and updated my test results in the comment.

@miri64 miri64 merged commit fc597cc into RIOT-OS:master Jan 31, 2024
3 checks passed
@miri64 miri64 deleted the github/enh/fix-deprecated-param branch January 31, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants