Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riotctrl.ctrl: provide abstract factory and factory for BOARD env #18

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Feb 16, 2021

This moves the factory from RIOT-OS/RIOT#15978 to riotctrl itself.

@fjmolinas
Copy link
Contributor

How will this evolve for the iotlab case? Would it be adding an ifdef based on IOTLAB_NODE being set?

@fjmolinas
Copy link
Contributor

How will this evolve for the iotlab case? Would it be adding an ifdef based on IOTLAB_NODE being set?

Needs a rebase BTW.

@miri64
Copy link
Member Author

miri64 commented Feb 18, 2021

How will this evolve for the iotlab case? Would it be adding an ifdef based on IOTLAB_NODE being set?

This here not really. IOTLAB_NODE would still be provided with env to get_ctrl(). But together with #13 and a factory for that, one could imagine a more sofisticated class that would make use of the collection class in #13.

@miri64
Copy link
Member Author

miri64 commented Feb 18, 2021

But if you would somehow make something with IOTLAB_NODE environment variable one could imagine a new mixin class for that environment variable.

@fjmolinas
Copy link
Contributor

How will this evolve for the iotlab case? Would it be adding an ifdef based on IOTLAB_NODE being set?

This here not really. IOTLAB_NODE would still be provided with env to get_ctrl(). But together with #13 and a factory for that, one could imagine a more sofisticated class that would make use of the collection class in #13.

anyway I'm jumping steps, please rebase!

@miri64 miri64 force-pushed the riotctrl.ctrl/feat/factory branch from e23b790 to ce7829b Compare February 18, 2021 10:17
@miri64
Copy link
Member Author

miri64 commented Feb 18, 2021

Rebased.

Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@fjmolinas fjmolinas merged commit b2d6df8 into RIOT-OS:master Feb 18, 2021
@miri64 miri64 deleted the riotctrl.ctrl/feat/factory branch February 18, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants