Multiple compilation fixes and one bugfix #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansuel
force-pushed
the
compilation-fixes
branch
from
b0eab10 to
3c6f8df
Compare
32bit systems have time_t set to long long int while 64bit system have time_t set to long int. This is problematic as in the busybox code this is not handled correctly and we have some casted to long and some not casted at all. Some arch (found this problem on a mt7621) may be restrictive about casting and crash with segmentation fault if time_t is cast to %ld instead of the correct %lld. This is the cause of RIPE-NCC/ripe-atlas-software-probe#74 Use the correct type and cast every time_t to (unsigned long long) so that eperd and condmv doesn't crash anymore and the measurement works correctly. Signed-off-by: Christian Marangi <[email protected]>
Cast size_t to long to mute warning on 32bit systems. Signed-off-by: Christian Marangi <[email protected]>
Cast sockaddr_in6 to sockaddr to mute compilation warning as documentation say for getsockname. Signed-off-by: Christian Marangi <[email protected]>
Mute some no previous prototype compilation warning found in atlas_unsafe, rxtxrpt_main and route_set_flags. Signed-off-by: Christian Marangi <[email protected]>
Ansuel
force-pushed
the
compilation-fixes
branch
from
3c6f8df to
be2a84c
Compare
|
Nice work @Ansuel, I'll pull these changes into our git repo and start testing on our platforms. Thanks! Regards, Michel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, by compiling this special busybox version on an openwrt buildroot I notice many compilation warning.
The idea is to fix some of them.
This also have a crucial commit that fix a segmentation fault on 32bit systems.
The related issue is here RIPE-NCC/ripe-atlas-software-probe#74