Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use deterministic permissions and times #18

Merged
merged 7 commits into from
Dec 11, 2023
Merged

Use deterministic permissions and times #18

merged 7 commits into from
Dec 11, 2023

Conversation

ties
Copy link
Member

@ties ties commented Dec 8, 2023

  • Use deterministic directory timestamps
  • Use deterministic permissions

Also make some test tweaks.

@ties ties force-pushed the feature/deterministic-permissions-and-times branch from aa3785f to bf25865 Compare December 8, 2023 12:55
lolepezy
lolepezy reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@lolepezy lolepezy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's okay, since tests pass, but it's a lot of changes clumped together, so I feel it needs quite some testing.

src/main/java/net/ripe/rpki/rsyncit/rsync/RsyncWriter.java Outdated Show resolved Hide resolved
src/main/java/net/ripe/rpki/rsyncit/rsync/RsyncWriter.java Show resolved Hide resolved
src/main/java/net/ripe/rpki/rsyncit/rsync/RsyncWriter.java Show resolved Hide resolved
@ties
Copy link
Member Author

ties commented Dec 11, 2023

I guess it's okay, since tests pass, but it's a lot of changes clumped together, so I feel it needs quite some testing.

Yes, needs a bit of time before it hits production.

@ties ties merged commit b6395df into main Dec 11, 2023
4 checks passed
@ties ties deleted the feature/deterministic-permissions-and-times branch December 11, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolepezy lolepezy lolepezy left review comments

@bjpbakker bjpbakker bjpbakker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ties @bjpbakker @lolepezy