Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make "R CMD CRAN incoming" a manual and optional check #381

Closed
jacobvjk opened this issue Jan 14, 2025 · 3 comments · Fixed by #388
Closed

make "R CMD CRAN incoming" a manual and optional check #381

jacobvjk opened this issue Jan 14, 2025 · 3 comments · Fixed by #388

Comments

@jacobvjk
Copy link
Member

jacobvjk commented Jan 14, 2025

the GH action R CMD CRAN incoming is producing noise that appears irrelevant to PRs that are not preparing a submission to CRAN (see #379 ). We therefore want to make it an action that has to be triggered manually and that we will use as a preparatory step for CRAN releases. It should not be blocking PRs to main that are not preparing for a release

@jacobvjk
Copy link
Member Author

fyi @jdhoffa @cjyetman

@cjyetman
Copy link
Member

@jacobvjk sorry to keep dragging this topic out, but I was considering the possibility of making this CI run automatically and always on PRs but fixing it so that it never fails/errors, but that it only posts a comment to the issue thread if it finds CRAN incoming notes. Might that be preferable?

@jacobvjk
Copy link
Member Author

probably better, because we won't have to remember triggering it manually. I am okay with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants