Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only post a message if CRAN incoming check finds notes #388

Merged
merged 4 commits into from
Jan 22, 2025
Merged

only post a message if CRAN incoming check finds notes #388

merged 4 commits into from
Jan 22, 2025

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Jan 22, 2025 •
edited
Loading

@cjyetman cjyetman requested a review from jacobvjk as a code owner January 22, 2025 03:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

R CMD check CRAN incoming feasibility check notes found:

Possibly misspelled words in DESCRIPTION:
  fludge (2:32)
The Title field should be in title case. Current version is:
  'Run 'PACTA' on Multiple fludge Loan Books Easily'
In title case that is:
  'Run 'PACTA' on Multiple Fludge Loan Books Easily'

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.97%. Comparing base (a918f5c) to head (25463a5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   79.97%   79.97%           
=======================================
  Files          29       29           
  Lines        3186     3186           
=======================================
  Hits         2548     2548           
  Misses        638      638

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-22 09:37 UTC

@cjyetman cjyetman requested a review from jdhoffa January 22, 2025 03:35
jdhoffa
jdhoffa approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cjyetman cjyetman merged commit 190409e into main Jan 22, 2025
12 checks passed
@cjyetman cjyetman deleted the cjyetman-patch-1 branch January 22, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobvjk jacobvjk jacobvjk approved these changes

@jdhoffa jdhoffa jdhoffa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make "R CMD CRAN incoming" a manual and optional check
3 participants
@cjyetman @jdhoffa @jacobvjk