Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add all scenarios to output of prep_emissions_trajectory() #40

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (d465509) to head (7dffdd2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
R/prep_emissions_trajectory.R 0.00% 12 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #40   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         21      21           
  Lines        996     997    +1     
=====================================
- Misses       996     997    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to bump the version in DESCRIPTION to Version: 0.0.0.9003 to pass CI

However, apart from that, I have tested this locally in coordination with RMI-PACTA/pacta-dashboard-svelte#121 and proved to myself that this functions as expected:
Screenshot 2024-12-05 at 13 01 50

@cjyetman
Copy link
Member Author

cjyetman commented Dec 5, 2024

You will need to bump the version in DESCRIPTION to Version: 0.0.0.9003 to pass CI

fine... I was waiting till it was likely to be merged because otherwise it seems likely to end up conflicting with multiple other open PRS... don't really understand how that's supposed to work

@cjyetman cjyetman marked this pull request as ready for review December 5, 2024 12:05
@cjyetman cjyetman requested a review from AlexAxthelm as a code owner December 5, 2024 12:05
@cjyetman cjyetman requested a review from jdhoffa December 5, 2024 12:05
@cjyetman cjyetman merged commit adebb07 into main Dec 5, 2024
20 checks passed
@cjyetman cjyetman deleted the add-scenarios-to-prep_emissions_trajectory-output branch December 5, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants