Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate workflow.pacta analysis in dashboard generation #49

Merged
merged 23 commits into from
Dec 13, 2024

Conversation

AlexAxthelm
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (0ec48f2) to head (c0c6807).
Report is 25 commits behind head on feat/34-enable-parameter-parsing.

Files with missing lines Patch % Lines
R/run_dashboard_workflow.R 0.00% 41 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           feat/34-enable-parameter-parsing     #49   +/-   ##
================================================================
  Coverage                              0.00%   0.00%           
================================================================
  Files                                    23      24    +1     
  Lines                                  1110    1151   +41     
================================================================
- Misses                                 1110    1151   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 12, 2024

Docker build status

commit_time git_sha image
2024-12-13T13:52:04Z c0c6807 ghcr.io/rmi-pacta/workflow.pacta.dashboard:feat-34-enable-parameter-parsing

Copy link

github-actions bot commented Dec 12, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-13 14:01 UTC

@jdhoffa
Copy link
Member

jdhoffa commented Dec 13, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RMI-PACTA.github.io/workflow.pacta.dashboard/pr-preview/pr-49/
on branch gh-pages at 2024-12-13 11:46 UTC

This is so awesome!

Just noting that for:
default_2023Q4
and
full_params_2023Q4

The portfolio-level technology mix plots don't appear:
Screenshot 2024-12-13 at 12 56 33

Interestingly, this seems to also be the case for our test CI on worklow.pacta.webapp:
See: RMI-PACTA/workflow.pacta.webapp#27

For example:
default_2023Q4

full_params_2023Q4

tests/config/default_2022Q4.json Outdated Show resolved Hide resolved
tests/config/full_params_2022Q4.json Outdated Show resolved Hide resolved
tests/config/full_params_2022Q4.json Outdated Show resolved Hide resolved
tests/config/full_params_2023Q4.json Outdated Show resolved Hide resolved
tests/config/full_params_2023Q4.json Outdated Show resolved Hide resolved
tests/config/default_2023Q4.json Show resolved Hide resolved
@jdhoffa
Copy link
Member

jdhoffa commented Dec 13, 2024

Interestingly, this seems to also be the case for our test CI on worklow.pacta.webapp: See: RMI-PACTA/workflow.pacta.webapp#27

@AlexAxthelm This leads me to believe that this is an artifact of the test data (or something else) and not directly related to this PR, so not-blocking.

I will look into the data side, and you can keep on with this 😊

@jdhoffa
Copy link
Member

jdhoffa commented Dec 13, 2024

I will look into the data side, and you can keep on with this 😊

Reproduced locally.

@jdhoffa
Copy link
Member

jdhoffa commented Dec 13, 2024

I will look into the data side, and you can keep on with this 😊

Reproduced locally.

The bug if that the selected selectscenario values for 2023Q4 point to 2022 scenarios:

Browse[1]> select_scenario_other
[1] "GECO2022_1.5C"
Browse[1]> select_scenario
[1] "WEO2022_NZE_2050"

I will review all configs across workflow.pacta.report, workflow.pacta.webapp and workflow.pacta.dashboard and fix that.

@jdhoffa
Copy link
Member

jdhoffa commented Dec 13, 2024

I will look into the data side, and you can keep on with this 😊

Reproduced locally.

The bug if that the selected selectscenario values for 2023Q4 point to 2022 scenarios:

Browse[1]> select_scenario_other
[1] "GECO2022_1.5C"
Browse[1]> select_scenario
[1] "WEO2022_NZE_2050"

I will review all configs across workflow.pacta.report, workflow.pacta.webapp and workflow.pacta.dashboard and fix that.

Should be resolved by:
RMI-PACTA/workflow.pacta.report#36
RMI-PACTA/workflow.pacta.webapp#28
f1c86b8
https://github.com/RMI-PACTA/workflow.pacta.dashboard/pull/47/files#r1883841078

jdhoffa added a commit to RMI-PACTA/workflow.pacta.webapp that referenced this pull request Dec 13, 2024
@AlexAxthelm AlexAxthelm marked this pull request as ready for review December 13, 2024 13:50
@AlexAxthelm
Copy link
Contributor Author

Merging this PR into #47

@AlexAxthelm AlexAxthelm merged commit dff0d53 into feat/34-enable-parameter-parsing Dec 13, 2024
29 checks passed
@AlexAxthelm AlexAxthelm deleted the integrate-workflow-pacta branch December 13, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants