Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit only entrypoint #107

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Audit only entrypoint #107

merged 3 commits into from
Dec 19, 2024

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Dec 19, 2024

minimal version of #106, which does not include changes to JSON schema

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 18.00%. Comparing base (7f1a47d) to head (2c970b8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/run_pacta.R 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   18.35%   18.00%   -0.35%     
==========================================
  Files           4        4              
  Lines         414      422       +8     
==========================================
  Hits           76       76              
- Misses        338      346       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Docker build status

commit_time git_sha image
2024-12-19T17:27:19Z 2c970b8 ghcr.io/rmi-pacta/workflow.pacta:pr-107

@AlexAxthelm AlexAxthelm marked this pull request as ready for review December 19, 2024 17:37
@AlexAxthelm AlexAxthelm requested a review from jdhoffa December 19, 2024 17:37
@AlexAxthelm AlexAxthelm self-assigned this Dec 19, 2024
@jdhoffa
Copy link
Member

jdhoffa commented Dec 19, 2024

@AlexAxthelm I don't think this will work with https://github.com/RMI-PACTA/workflow.pacta.webapp/pull/32/files

In https://github.com/RMI-PACTA/workflow.pacta.webapp/pull/32/files, we are calling the function workflow.pacta.webapp::run_webapp_workflow, so it is that one that needs to gain the arguments I believe?
I don't think we ever actually call workflow.pacta::run_pacta

@AlexAxthelm AlexAxthelm merged commit c923fb6 into main Dec 19, 2024
28 of 30 checks passed
@AlexAxthelm AlexAxthelm deleted the audit-only-entrypoint branch December 19, 2024 19:00
AlexAxthelm added a commit to RMI-PACTA/workflow.pacta.webapp that referenced this pull request Dec 19, 2024
jdhoffa added a commit to RMI-PACTA/workflow.pacta.webapp that referenced this pull request Dec 20, 2024
* gains `run_analysis` script

* only run analysis if necessary

* Revert "only run analysis if necessary"

This reverts commit dcc7f35.

* bump version

* Rename file

* Use dev version of `workflow.pacta`

access to new `run_audit` flag

* Add audit-only test step

* Fix: line continuation

* Use simple shell script as entrypoint

* Change permissions on shell script

* Don't pass all args, (just the first) to entrypoint

* Add Dockerignore

* POint entrypoint to correct R script

* Trigger CI with cache bust on DESCRIPTION

* Add run_audit flag to `run_webapp_workflow`

* Render Docs

* INclude `workflow.pacta.report` in inherit path

* Revert to main branch of dependency

following merge of RMI-PACTA/workflow.pacta#107

---------

Co-authored-by: Alex Axthelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants