Enable cpp core guidlines checks. (#3723)

ROCm · Jan 4, 2025 · 5f9e048 · 5f9e048
1 parent 13159b3
commit 5f9e048
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -208,7 +208,6 @@ rocm_enable_clang_tidy(
         -clang-diagnostic-disabled-macro-expansion
         -clang-diagnostic-extern-c-compat
         -clang-diagnostic-unused-command-line-argument
-        -cppcoreguidelines-avoid-capture-default-when-capturing-this
         -cppcoreguidelines-avoid-const-or-ref-data-members
         -cppcoreguidelines-avoid-do-while
         -cppcoreguidelines-explicit-virtual-functions
@@ -222,7 +221,6 @@ rocm_enable_clang_tidy(
         -cppcoreguidelines-pro-type-reinterpret-cast
         -cppcoreguidelines-pro-type-union-access
         -cppcoreguidelines-pro-type-vararg
-        -cppcoreguidelines-rvalue-reference-param-not-moved
         -cppcoreguidelines-special-member-functions
         -cppcoreguidelines-use-default-member-init
         -cppcoreguidelines-virtual-class-destructor

diff --git a/src/include/migraphx/program.hpp b/src/include/migraphx/program.hpp
@@ -112,7 +112,7 @@ struct MIGRAPHX_EXPORT program
                      std::size_t batch = 1,
                      bool detailed     = false) const;
 
-    void mark(const parameter_map& params, marker&& m);
+    void mark(const parameter_map& params, marker m);
 
     value to_value() const;
     void from_value(const value& v);

diff --git a/src/program.cpp b/src/program.cpp
@@ -887,13 +887,12 @@ std::string perf_group(instruction_ref ins, bool detailed)
     return result;
 }
 
-void program::mark(const parameter_map& params, marker&& m)
+void program::mark(const parameter_map& params, marker m)
 {
     auto& ctx = this->impl->contexts;
     // Run once by itself
     eval(params);
     this->finish();
-    // Start marking
     m.mark_start(*this);
     generic_eval(*this, ctx, params, [&](auto ins, auto f) {
         argument result;

diff --git a/test/ref/add.cpp b/test/ref/add.cpp
@@ -170,7 +170,7 @@ TEST_CASE(fp32_fp16_test)
         return p;
     };
 
-    auto test_case = [&](std::vector<std::string>&& op_names) {
+    auto test_case = [&](const std::vector<std::string>& op_names) {
         std::vector<float> gold_res = {2.0, 4.0, 6.0, 8.0, 10.0, 12.0};
         auto p                      = create_program();
         migraphx::quantize_fp16(p, op_names);