Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for the CK + HIPRTC #2251

Merged
merged 20 commits into from
Sep 29, 2023
Merged

Changes for the CK + HIPRTC #2251

merged 20 commits into from
Sep 29, 2023

Conversation

umangyadav
Copy link
Member

@umangyadav umangyadav commented Sep 26, 2023

CK commit SHA pointes to the migx-jit-lib-hiprtc branch which requires some updates but has changes to make it CK work with hiprtc. I'll update the commit hash once that update is finished.

For now, testing to see if it passes the Jenkins.

Fixes #1831

@umangyadav umangyadav added the skip bot checks Skips the Performance and Accuracy CI tests label Sep 26, 2023
@umangyadav umangyadav requested a review from pfultz2 September 27, 2023 00:35
@umangyadav umangyadav marked this pull request as ready for review September 27, 2023 00:35
@umangyadav umangyadav requested a review from turneram September 27, 2023 00:36
@umangyadav umangyadav self-assigned this Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2251 (14de58c) into develop (3338289) will not change coverage.
The diff coverage is n/a.

❗ Current head 14de58c differs from pull request most recent head 3a2d564. Consider uploading reports for the commit 3a2d564 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2251   +/-   ##
========================================
  Coverage    91.49%   91.49%           
========================================
  Files          430      430           
  Lines        16129    16129           
========================================
  Hits         14758    14758           
  Misses        1371     1371           

@causten causten merged commit 4188c38 into develop Sep 29, 2023
@causten causten deleted the ck_hiprtc branch September 29, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip bot checks Skips the Performance and Accuracy CI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find workarounds for CK to work with hiprtc
4 participants