-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added set_bypass() call #3116
added set_bypass() call #3116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
For the other reviewers, adding the extra check in fused_reduce operator will get coverage for this issue with the current unit tests, so there is no need to write a new unit test. Also its very likely such unit test would be removed in the future, which I dont have time to explain now. |
Don't be too quick! The change broke an existing test, which I'm working on now. So we have code coverage whether we want it or not. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3116 +/- ##
========================================
Coverage 91.82% 91.82%
========================================
Files 486 486
Lines 18991 18994 +3
========================================
+ Hits 17438 17441 +3
Misses 1553 1553 ☔ View full report in Codecov by Sentry. |
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
…nto bypass_in_fuse_reduce
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3116 +/- ##
========================================
Coverage 91.82% 91.82%
========================================
Files 486 486
Lines 18990 18993 +3
========================================
+ Hits 17437 17440 +3
Misses 1553 1553 ☔ View full report in Codecov by Sentry. |
Bug fix: added a
set_bypass()
call that was missing from thereduce_reshape
variant of therewrite_reshapes
pass in fusion reduction (the other variants already have it). This sets a flag to prevent the created module from being fused again (i.e. subsequent compiler passes that see the flag skip over the module), which could lead to an exception because it would try to create afused_reduce
instruction with an invalid argument list. Closes Issue #3033