Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tidy check by getting rid of unused variables. #3603

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

taylding-amd
Copy link
Contributor

@taylding-amd taylding-amd commented Nov 8, 2024

Fix #3471, removed unused variables, and re-enabled the tidy check.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (a65ac8d) to head (21f37a0).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3603      +/-   ##
===========================================
- Coverage    92.17%   92.17%   -0.01%     
===========================================
  Files          513      513              
  Lines        21563    21561       -2     
===========================================
- Hits         19876    19874       -2     
  Misses        1687     1687              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TedThemistokleous TedThemistokleous added simple small or simple changes Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR labels Nov 8, 2024
@TedThemistokleous
Copy link
Collaborator

LGTM

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
c6a86d
Rate old
4b96e1
Diff Compare
torchvision-resnet50 64 3,258.71 3,260.40 -0.05%
torchvision-resnet50_fp16 64 6,991.67 6,981.88 0.14%
torchvision-densenet121 32 2,433.72 2,436.50 -0.11%
torchvision-densenet121_fp16 32 4,057.98 4,081.96 -0.59%
torchvision-inceptionv3 32 1,639.04 1,638.04 0.06%
torchvision-inceptionv3_fp16 32 2,761.10 2,760.86 0.01%
cadene-inceptionv4 16 776.91 776.56 0.04%
cadene-resnext64x4 16 811.63 811.67 -0.01%
slim-mobilenet 64 7,535.22 7,540.50 -0.07%
slim-nasnetalarge 64 211.47 211.49 -0.01%
slim-resnet50v2 64 3,505.77 3,506.73 -0.03%
bert-mrpc-onnx 8 1,151.62 1,147.08 0.40%
bert-mrpc-tf 1 463.74 465.87 -0.46%
pytorch-examples-wlang-gru 1 422.45 423.73 -0.30%
pytorch-examples-wlang-lstm 1 383.33 389.07 -1.47%
torchvision-resnet50_1 1 810.10 788.22 2.78%
cadene-dpn92_1 1 398.58 402.19 -0.90%
cadene-resnext101_1 1 384.43 382.83 0.42%
onnx-taau-downsample 1 342.91 343.07 -0.04%
dlrm-criteoterabyte 1 33.33 33.34 -0.01%
dlrm-criteoterabyte_fp16 1 52.73 52.75 -0.05%
agentmodel 1 8,584.94 8,325.15 3.12% 🔆
unet_fp16 2 58.89 58.80 0.15%
resnet50v1_fp16 1 1,006.60 953.06 5.62% 🔆
resnet50v1_int8 1 1,025.10 1,005.99 1.90%
bert_base_cased_fp16 64 1,170.36 1,170.44 -0.01%
bert_large_uncased_fp16 32 363.75 363.37 0.10%
bert_large_fp16 1 199.93 198.99 0.47%
distilgpt2_fp16 16 2,205.47 2,201.23 0.19%
yolov5s 1 550.92 536.00 2.78%
tinyllama 1 43.42 43.45 -0.07%
vicuna-fastchat 1 173.39 174.10 -0.41%
whisper-tiny-encoder 1 418.39 418.74 -0.08%
whisper-tiny-decoder 1 423.91 425.97 -0.48%

Check results before merge 🔆

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten causten merged commit e0b3ec5 into develop Nov 13, 2024
33 of 35 checks passed
@causten causten deleted the issue_3471 branch November 13, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR simple small or simple changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncomment - -bugprone-unused-local-non-trivial-variable
5 participants