Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rocm-docs-core from 1.8.3 to 1.8.4 in /docs/sphinx #3626

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 18, 2024

Bumps rocm-docs-core from 1.8.3 to 1.8.4.

Release notes

Sourced from rocm-docs-core's releases.

v1.8.4 (2024-11-15)

Fix

  • resort import statements
  • separate import time from other import statements as time is standard python library but others are third party
  • sort import statement
  • add retry loop around http request
  • header.jinja: Replace http with https in repo URL

[main fecc3f9] bump: version 1.8.3 → 1.8.4 3 files changed, 14 insertions(+), 4 deletions(-)

Changelog

Sourced from rocm-docs-core's changelog.

v1.8.4 (2024-11-15)

Fix

  • resort import statements
  • separate import time from other import statements as time is standard python library but others are third party
  • sort import statement
  • add retry loop around http request
  • header.jinja: Replace http with https in repo URL
Commits
  • fecc3f9 bump: version 1.8.3 → 1.8.4
  • 461694b Merge pull request #1024 from ROCm/amd/alexxu12/headerFix
  • f0a51b2 style(theme.py): Apply black formatting to theme.py
  • 537f2d4 fix: resort import statements
  • 283e201 fix: separate import time from other import statements as time is standard py...
  • 6e9fc8c fix: sort import statement
  • 9d08eb8 fix: add retry loop around http request
  • 3cc8b6c Merge pull request #1023 from ROCm/dependabot/pip/deprecated-1.2.15
  • 17d230a Merge pull request #1022 from ROCm/dependabot/pip/ruff-0.7.4
  • b827b79 build: bump deprecated from 1.2.14 to 1.2.15
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.8.3 to 1.8.4.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.8.3...v1.8.4)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from causten as a code owner November 18, 2024 12:40
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (b39a938) to head (81877b1).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3626   +/-   ##
========================================
  Coverage    92.18%   92.18%           
========================================
  Files          513      513           
  Lines        21576    21576           
========================================
  Hits         19889    19889           
  Misses        1687     1687           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
81877b
Rate old
b39a93
Diff Compare
torchvision-resnet50 64 3,256.91 3,257.00 -0.00%
torchvision-resnet50_fp16 64 6,985.56 6,984.63 0.01%
torchvision-densenet121 32 2,438.10 2,433.00 0.21%
torchvision-densenet121_fp16 32 4,079.80 4,080.77 -0.02%
torchvision-inceptionv3 32 1,628.19 1,627.81 0.02%
torchvision-inceptionv3_fp16 32 2,743.48 2,746.31 -0.10%
cadene-inceptionv4 16 765.89 764.38 0.20%
cadene-resnext64x4 16 811.37 811.17 0.02%
slim-mobilenet 64 7,472.65 7,464.41 0.11%
slim-nasnetalarge 64 208.46 208.42 0.02%
slim-resnet50v2 64 3,440.77 3,439.84 0.03%
bert-mrpc-onnx 8 1,147.38 1,153.73 -0.55%
bert-mrpc-tf 1 463.67 497.12 -6.73% 🔴
pytorch-examples-wlang-gru 1 426.95 432.34 -1.25%
pytorch-examples-wlang-lstm 1 382.74 390.79 -2.06%
torchvision-resnet50_1 1 802.09 810.22 -1.00%
cadene-dpn92_1 1 434.22 397.26 9.30% 🔆
cadene-resnext101_1 1 376.12 383.26 -1.86%
onnx-taau-downsample 1 346.57 345.68 0.26%
dlrm-criteoterabyte 1 33.36 33.33 0.09%
dlrm-criteoterabyte_fp16 1 52.73 52.75 -0.03%
agentmodel 1 8,303.79 9,841.45 -15.62% 🔴
unet_fp16 2 58.94 58.82 0.19%
resnet50v1_fp16 1 941.54 956.50 -1.56%
resnet50v1_int8 1 1,002.90 1,048.16 -4.32% 🔴
bert_base_cased_fp16 64 1,170.94 1,170.84 0.01%
bert_large_uncased_fp16 32 363.63 363.68 -0.01%
bert_large_fp16 1 198.60 200.40 -0.90%
distilgpt2_fp16 16 2,199.48 2,199.24 0.01%
yolov5s 1 529.98 534.53 -0.85%
tinyllama 1 43.71 43.46 0.59%
vicuna-fastchat 1 173.72 175.10 -0.78%
whisper-tiny-encoder 1 418.12 418.56 -0.10%
whisper-tiny-decoder 1 436.55 434.23 0.54%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 19, 2024

Superseded by #3631.

@dependabot dependabot bot closed this Nov 19, 2024
@dependabot dependabot bot deleted the dependabot/pip/docs/sphinx/rocm-docs-core-1.8.4 branch November 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant