Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __AMDGCN_WAVEFRONT_SIZE for deprecation #3714

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

CharlieL7
Copy link
Collaborator

  • New compiler is deprecating this macro
  • Works on MI300X with compiler staging docker

@CharlieL7 CharlieL7 self-assigned this Dec 13, 2024
@CharlieL7 CharlieL7 requested a review from causten as a code owner December 13, 2024 19:39
@TedThemistokleous TedThemistokleous added roadmap Tasks to finish for a release Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR labels Dec 13, 2024
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
cf40d3
Rate old
79a256
Diff Compare
torchvision-resnet50 64 1,611.86 3,254.68 -50.48% 🔴
torchvision-resnet50_fp16 64 6,526.62 6,988.98 -6.62% 🔴
torchvision-densenet121 32 2,419.39 2,435.20 -0.65%
torchvision-densenet121_fp16 32 2,341.95 4,089.35 -42.73% 🔴
torchvision-inceptionv3 32 1,634.32 1,629.15 0.32%
torchvision-inceptionv3_fp16 32 2,743.06 2,750.39 -0.27%
cadene-inceptionv4 16 765.72 765.66 0.01%
cadene-resnext64x4 16 812.84 812.33 0.06%
slim-mobilenet 64 7,469.78 7,465.36 0.06%
slim-nasnetalarge 64 209.05 209.02 0.01%
slim-resnet50v2 64 3,440.19 3,439.27 0.03%
bert-mrpc-onnx 8 1,147.64 1,145.81 0.16%
bert-mrpc-tf 1 473.14 466.39 1.45%
pytorch-examples-wlang-gru 1 413.30 421.94 -2.05%
pytorch-examples-wlang-lstm 1 396.40 381.01 4.04% 🔆
torchvision-resnet50_1 1 798.67 763.70 4.58% 🔆
cadene-dpn92_1 1 435.14 434.24 0.21%
cadene-resnext101_1 1 382.46 383.59 -0.29%
onnx-taau-downsample 1 346.16 346.01 0.05%
dlrm-criteoterabyte 1 33.36 33.33 0.10%
dlrm-criteoterabyte_fp16 1 52.73 52.73 -0.01%
agentmodel 1 8,177.42 8,229.23 -0.63%
unet_fp16 2 58.75 58.93 -0.31%
resnet50v1_fp16 1 932.81 1,025.60 -9.05% 🔴
resnet50v1_int8 1 1,017.09 1,052.08 -3.33% 🔴
bert_base_cased_fp16 64 1,168.54 1,169.64 -0.09%
bert_large_uncased_fp16 32 362.88 363.34 -0.13%
bert_large_fp16 1 200.31 198.80 0.76%
distilgpt2_fp16 16 2,201.00 2,201.30 -0.01%
yolov5s 1 531.67 529.55 0.40%
tinyllama 1 43.64 43.36 0.64%
vicuna-fastchat 1 173.39 170.51 1.69%
whisper-tiny-encoder 1 418.16 417.88 0.07%
whisper-tiny-decoder 1 427.60 425.43 0.51%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (f9e276b) to head (31d83a1).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3714   +/-   ##
========================================
  Coverage    92.18%   92.18%           
========================================
  Files          514      514           
  Lines        21780    21780           
========================================
  Hits         20078    20078           
  Misses        1702     1702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CharlieL7 CharlieL7 requested a review from pfultz2 December 16, 2024 19:12
@causten causten merged commit ebf82f6 into develop Dec 17, 2024
42 of 45 checks passed
@causten causten deleted the wavefront_size_fix branch December 17, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR roadmap Tasks to finish for a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants