Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native fp16 type #3720

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Use native fp16 type #3720

merged 3 commits into from
Dec 19, 2024

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Dec 17, 2024

Fixes #3710.

@pfultz2 pfultz2 marked this pull request as ready for review December 17, 2024 23:16
@pfultz2 pfultz2 requested a review from causten as a code owner December 17, 2024 23:16
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (ebf82f6) to head (0b3fb8a).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3720   +/-   ##
========================================
  Coverage    92.18%   92.18%           
========================================
  Files          514      514           
  Lines        21780    21780           
========================================
  Hits         20078    20078           
  Misses        1702     1702

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfultz2 pfultz2 self-assigned this Dec 18, 2024
@TedThemistokleous TedThemistokleous added the bugfix Fixes a bug found in the code. label Dec 18, 2024
@causten causten merged commit 762db90 into develop Dec 19, 2024
41 of 45 checks passed
@causten causten deleted the remove-hip-type branch December 19, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TedThemistokleous TedThemistokleous TedThemistokleous approved these changes

@richagadgil richagadgil richagadgil approved these changes

@causten causten Awaiting requested review from causten causten is a code owner

@kahmed10 kahmed10 Awaiting requested review from kahmed10

@aarushjain29 aarushjain29 Awaiting requested review from aarushjain29

Assignees

@pfultz2 pfultz2

Labels
bugfix Fixes a bug found in the code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NHWC issue on YoloX
4 participants
@pfultz2 @richagadgil @TedThemistokleous @causten