Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cpp core guidlines checks. #3723

Merged
merged 9 commits into from
Jan 4, 2025
Merged

Enable cpp core guidlines checks. #3723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f5c6c16
Enable cpp core guidlines checks.
taylding-amd Dec 18, 2024
f38f967
Merge branch 'develop' into issue_2231
taylding-amd Dec 18, 2024
872e4e4
Merge branch 'develop' into issue_2231
taylding-amd Dec 19, 2024
b392b2b
Merge branch 'develop' into issue_2231
TedThemistokleous Dec 20, 2024
0665918
Enable cppcoreguidelines-rvalue-reference-param-not-moved check
taylding-amd Dec 20, 2024
4502165
Fix format
taylding-amd Dec 20, 2024
fad9e4f
Merge branch 'develop' into issue_2231
taylding-amd Dec 20, 2024
4ccbb4f
Resolve comments
taylding-amd Dec 30, 2024
0b3e6db
Merge branch 'develop' into issue_2231
taylding-amd Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,6 @@ rocm_enable_clang_tidy(
-clang-diagnostic-disabled-macro-expansion
-clang-diagnostic-extern-c-compat
-clang-diagnostic-unused-command-line-argument
-cppcoreguidelines-avoid-capture-default-when-capturing-this
-cppcoreguidelines-avoid-const-or-ref-data-members
-cppcoreguidelines-avoid-do-while
-cppcoreguidelines-explicit-virtual-functions
Expand All @@ -222,7 +221,6 @@ rocm_enable_clang_tidy(
-cppcoreguidelines-pro-type-reinterpret-cast
-cppcoreguidelines-pro-type-union-access
-cppcoreguidelines-pro-type-vararg
-cppcoreguidelines-rvalue-reference-param-not-moved
-cppcoreguidelines-special-member-functions
-cppcoreguidelines-use-default-member-init
-cppcoreguidelines-virtual-class-destructor
Expand Down
2 changes: 1 addition & 1 deletion src/include/migraphx/program.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ struct MIGRAPHX_EXPORT program
std::size_t batch = 1,
bool detailed = false) const;

void mark(const parameter_map& params, marker&& m);
void mark(const parameter_map& params, marker m);

value to_value() const;
void from_value(const value& v);
Expand Down
3 changes: 1 addition & 2 deletions src/program.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,13 +887,12 @@ std::string perf_group(instruction_ref ins, bool detailed)
return result;
}

void program::mark(const parameter_map& params, marker&& m)
void program::mark(const parameter_map& params, marker m)
{
auto& ctx = this->impl->contexts;
// Run once by itself
eval(params);
this->finish();
// Start marking
m.mark_start(*this);
generic_eval(*this, ctx, params, [&](auto ins, auto f) {
argument result;
Expand Down
2 changes: 1 addition & 1 deletion test/ref/add.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ TEST_CASE(fp32_fp16_test)
return p;
};

auto test_case = [&](std::vector<std::string>&& op_names) {
auto test_case = [&](const std::vector<std::string>& op_names) {
std::vector<float> gold_res = {2.0, 4.0, 6.0, 8.0, 10.0, 12.0};
auto p = create_program();
migraphx::quantize_fp16(p, op_names);
Expand Down
Loading