Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting fixes for PEP-8 conformance. #1260

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Linting fixes for PEP-8 conformance. #1260

merged 1 commit into from
Jan 17, 2024

Conversation

Bazifrasool
Copy link
Contributor

Fixed linting issues for pep8 conformance.
https://peps.python.org/pep-0008/#programming-recommendations

  • Use is not operator rather than not ... is. While both expressions are functionally identical, the former is more readable and preferred
  • Instead of != None use is not None
  • Remove trailing semicolons

@Bazifrasool Bazifrasool changed the title Linting fixes for conformance. Linting fixes for PEP-8 conformance. Jan 2, 2024
@Bazifrasool
Copy link
Contributor Author

@kiritigowda for review, should be a quick one.

@kiritigowda kiritigowda self-assigned this Jan 2, 2024
@kiritigowda kiritigowda added the enhancement New feature or request label Jan 2, 2024
@kiritigowda kiritigowda changed the base branch from master to develop January 4, 2024 21:24
@kiritigowda kiritigowda requested a review from rrawther January 4, 2024 21:24
@kiritigowda
Copy link
Collaborator

@LakshmiKumar23 can you review this PR?

@LakshmiKumar23
Copy link
Contributor

@kiritigowda Setup script runs ok on ub22 lev2 docker. Ok to merge

@kiritigowda kiritigowda merged commit d3794e3 into ROCm:develop Jan 17, 2024
14 of 17 checks passed
kiritigowda pushed a commit that referenced this pull request Jan 18, 2024
@Bazifrasool @kiritigowda
Linting fixes for pep8 conformance. (#1260)
06d3afa
@Bazifrasool Bazifrasool deleted the linting-fixes branch January 18, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LakshmiKumar23 LakshmiKumar23 LakshmiKumar23 approved these changes

@AryanSalmanpour AryanSalmanpour Awaiting requested review from AryanSalmanpour

@rrawther rrawther Awaiting requested review from rrawther rrawther is a code owner

Assignees

@kiritigowda kiritigowda

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bazifrasool @kiritigowda @LakshmiKumar23