kfdtest: fix resource leakage

Resource allocated in SetUp/HsaNodeInfo::Init, needs be delete in TearDown/HsaNodeInfo::Delete. Signed-off-by: James Zhu <[email protected]>
ROCm · Feb 25, 2025 · f8d8b80 · f8d8b80
1 parent 322a794
commit f8d8b80
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/libhsakmt/tests/kfdtest/src/KFDBaseComponentTest.cpp b/libhsakmt/tests/kfdtest/src/KFDBaseComponentTest.cpp
@@ -166,6 +166,7 @@ void KFDBaseComponentTest::TearDown() {
 
     closelog();
 
+    m_NodeInfo.Delete();
     ROUTINE_END
 }
 

diff --git a/libhsakmt/tests/kfdtest/src/KFDTestUtil.cpp b/libhsakmt/tests/kfdtest/src/KFDTestUtil.cpp
@@ -609,13 +609,19 @@ bool HsaNodeInfo::Init(int NumOfNodes) {
     return ret;
 }
 
-HsaNodeInfo::~HsaNodeInfo() {
+void HsaNodeInfo::Delete() {
     const HsaNodeProperties *nodeProperties;
 
     for (unsigned int i = 0; i < m_HsaNodeProps.size(); i++)
         delete m_HsaNodeProps.at(i);
 
     m_HsaNodeProps.clear();
+    m_NodesWithGPU.clear();
+    m_NodesWithoutGPU.clear();
+}
+
+HsaNodeInfo::~HsaNodeInfo() {
+    Delete();
 }
 
 const std::vector<int>& HsaNodeInfo::GetNodesWithGPU() const {

diff --git a/libhsakmt/tests/kfdtest/src/KFDTestUtil.hpp b/libhsakmt/tests/kfdtest/src/KFDTestUtil.hpp
@@ -216,6 +216,7 @@ class HsaNodeInfo {
     ~HsaNodeInfo();
 
     bool Init(int NumOfNodes);
+    void Delete();
 
     /* This function should be deprecated soon. This for transistion purpose only
      * Currently, KfdTest is designed to test only ONE node. This function acts
-Original file line number
+Diff line change
@@ Expand Up / @@ -166,6 +166,7 @@ void KFDBaseComponentTest::TearDown() { @@
         closelog();
+        m_NodeInfo.Delete();
         ROUTINE_END
     }
@@ Expand Down @@