Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPT] Tail Loop Optimization #1567

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+721 −183
Open

[OPT] Tail Loop Optimization #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 36 additions & 10 deletions tensilelite/Tensile/KernelWriter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2627,33 +2627,59 @@ def kernelBody( self, kernel, tensorParametersA, tensorParametersB ):
# if swapGlobalRoad is true, swap the order of global read (B->A)
tensorParameters1st = tensorParametersA
tensorParameters2nd = tensorParametersB
tailLoopOpt1st = kernel["tailLoopOptA"]
tailLoopOpt2nd = kernel["tailLoopOptB"]

tc1 = 'A'
tc2 = 'B'
if self.isSwapGlobalReadOrderForDtvOrDtl(kernel):
tensorParameters1st, tensorParameters2nd = tensorParameters2nd, tensorParameters1st
tailLoopOpt1st, tailLoopOpt2nd = tailLoopOpt2nd, tailLoopOpt1st
tc1, tc2 = tc2, tc1

globalReadMode1st = 2 if (((tensorParameters1st["glvw"] * tensorParameters1st["bpeGR"]) < 4) or \
kernel["tailLoopOpt"] == False) else 0
tailLoopOpt1st == False) else 3
globalReadMode2nd = 2 if (((tensorParameters2nd["glvw"] * tensorParameters2nd["bpeGR"]) < 4) or \
kernel["tailLoopOpt"] == False) else 0
globalReadMode1st = 0 if tensorParameters1st["isSwizzled"] else globalReadMode1st
globalReadMode2nd = 0 if tensorParameters2nd["isSwizzled"] else globalReadMode2nd
tailLoopOpt2nd == False) else 3

globalReadMode1st = 3 if tensorParameters1st["isSwizzled"] else globalReadMode1st
globalReadMode2nd = 3 if tensorParameters2nd["isSwizzled"] else globalReadMode2nd
Copy link
Contributor

@aazz44ss aazz44ss Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put more comments about what are globalReadMode1st and globalReadMode2nd here.


module.addComment1("Update M0 for DTLDS")
moduleTmp = self.directToLdsM0Update(kernel, 1, tensorParameters1st)
module.add(replaceHolder(moduleTmp, 0))
module.addComment1("Tail global read %s"%tc1)
module.add(self.globalReadDo(kernel, globalReadMode1st, tensorParameters1st))
if tailLoopOpt1st and (globalReadMode1st == 2):
module.add(self.doTailLoopOpt(kernel, tensorParameters1st))
else:
module.add(self.globalReadDo(kernel, globalReadMode1st, tensorParameters1st))
module.addComment1("Update M0 for DTLDS")
moduleTmp = self.directToLdsM0Update(kernel, 1, tensorParameters2nd)
module.add(replaceHolder(moduleTmp, 0))
module.addComment1("Tail global read %s"%tc2)
module.add(self.globalReadDo(kernel, globalReadMode2nd, tensorParameters2nd))
if kernel["tailLoopOpt"] and \
(((tensorParameters1st["glvw"] * tensorParameters1st["bpeGR"]) >= 4) or \
((tensorParameters2nd["glvw"] * tensorParameters2nd["bpeGR"]) >= 4)):
module.add(self.tailLoopGlobalRead(kernel, tensorParameters1st, tensorParameters2nd))
if tailLoopOpt2nd and (globalReadMode2nd == 2):
module.add(self.doTailLoopOpt(kernel, tensorParameters2nd))
else:
module.add(self.globalReadDo(kernel, globalReadMode2nd, tensorParameters2nd))

doA = False
doB = False
if globalReadMode1st == 3:
if tc1 == 'A':
doA = True if (tensorParameters1st["bpeGR"] % 4 != 0) and (not kernel["ProblemType"]["TLU%s"%(tc1)]) else False
else:
doB = True if (tensorParameters1st["bpeGR"] % 4 != 0) and (not kernel["ProblemType"]["TLU%s"%(tc1)]) else False
if globalReadMode2nd == 3:
if tc2 == 'A':
doA = True if (tensorParameters2nd["bpeGR"] % 4 != 0) and (not kernel["ProblemType"]["TLU%s"%(tc2)]) else False
else:
doB = True if (tensorParameters2nd["bpeGR"] % 4 != 0) and (not kernel["ProblemType"]["TLU%s"%(tc2)]) else False

if doA or doB:
if tc1 == 'A':
module.add(self.tailLoopGlobalRead(kernel, tensorParameters1st, tensorParameters2nd, doA, doB))
else:
module.add(self.tailLoopGlobalRead(kernel, tensorParameters2nd, tensorParameters1st, doA, doB))
module.add(self._wait(kernel, tensorParameters1st, tensorParameters2nd, 0, -1, -1, "2wait for global read"))
module.add(self._syncThreads(kernel))

Expand Down
Loading