Release and allocate VGPR resoures in tail loop. #1586
+458
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcman2
requested review from
jichangjichang,
KKyang,
vin-huang,
imcarsonliao,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
hcman2
changed the title
hcman2
force-pushed
the
vgpr
branch
2 times, most recently
from
4e58993 to
a053a82
Compare
hcman2
force-pushed
the
vgpr
branch
2 times, most recently
from
05127bf to
33928c3
Compare
solaslin
added
the
noCI
hcman2
force-pushed
the
vgpr
branch
5 times, most recently
from
a31b071 to
7f6c281
Compare
1. Add a VGPR base index definition. 2. Rearange VGPR index order for further optimization. 3. Re-allocate VGPR for tail loop. Fix 4 potential bugs: 1. DTV will use the Valu VGPRs which is released in the beginning of tail loop. 2. BiasSum Valu VGPR should be used when endSum but is released in the beginning of tail loop. 3. _replaceActBranchLabel() always replaces label without postfix. However we should check the label we'd really like to replace with. 4. For DTL, numVgprG2LAllocated is not set so that it will be default=-1. This change is the first step to optimize the VGPR usage in unroll loop. In general, the VGPRs usage in the unrolled loop is dependent from the tail. In tail, the VGPR can be used more effectively.
hcman2
added
noCI
hcman2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 4 potential bugs:
However we should check the label we'd really like to replace with.
default=-1.