Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reinterpreted structs to match #1596

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

reinterpreted structs to match #1596

wants to merge 1 commit into from
+30 −1

Conversation

TorreZuk
Copy link
Contributor

  • test matching struct for algo API

daineAMD
daineAMD approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@daineAMD daineAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to have needed parity between rocblaslt_matmul_algo and hipblasLtMatmulAlgo_t

@TorreZuk
Copy link
Contributor Author

rocblaslt_matmul_heuristic_result contains this rocblaslt_matmul_algo struct (and it's hipblaslt interface structs do the same) so that is the real problem if they don't match as reinterpret cast is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichangjichang jichangjichang jichangjichang approved these changes

@daineAMD daineAMD daineAMD approved these changes

@KKyang KKyang Awaiting requested review from KKyang KKyang is a code owner

@vin-huang vin-huang Awaiting requested review from vin-huang vin-huang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

@hcman2 hcman2 Awaiting requested review from hcman2 hcman2 is a code owner

@Serge45 Serge45 Awaiting requested review from Serge45 Serge45 is a code owner

@Jinp800125 Jinp800125 Awaiting requested review from Jinp800125 Jinp800125 is a code owner

@TonyYHsieh TonyYHsieh Awaiting requested review from TonyYHsieh TonyYHsieh is a code owner

@solaslin solaslin Awaiting requested review from solaslin solaslin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TorreZuk @jichangjichang @daineAMD