Make daily sync permissions at the workflow level and fix merge CI #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleshofer
requested review from
JehandadKhan,
Ruturaj4,
mrodden and
zahiqbal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does two things:
contents: writepermission at the job level causes thegh repo syncjob to fail with an HTTP403 error.rocm-maincode into our middle branch created by CI so that CI won't be run (I thought we could originally disable this through the GUI, but that's not the case since upstream CI sits in the same file as our CI).Story: https://github.com/ROCm/frameworks-internal/issues/9948