non-hipGraph MSCCL++ tests for allReduce and allGather #1503
+339
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neUtils so that it can be included in several tests
isaki001
requested review from
wenkaidu,
gilbertlee-amd,
akolliasAMD,
edgargabriel,
PedramAlizadeh,
nusislam,
nileshnegi,
KawtharShafie,
AtlantaPepsi,
mberenjk,
corey-derochie-amd,
mustafabar,
thananon,
JhaShweta1 and
haripriya-amd
as code owners
corey-derochie-amd
previously requested changes
Jan 23, 2025
isaki001
changed the title
corey-derochie-amd
requested changes
Jan 24, 2025
…teNCCLid only from parent process
corey-derochie-amd
previously approved these changes
Jan 28, 2025
…tandaloneUtils is for the Standalone tests. Renamed the functions to be slightly more accurate and follow existing naming conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Do not mention proprietary info or link to internal work items in this PR.
Work item: "Internal", or link to GitHub issue (if applicable).
What were the changes?
Added functional test for allGather and allReduce when utilizing MSCCL++ kernels in non-hipGraph mode, with/without managed memory.
Why were the changes made?
No test for non-hipGraph mode user-buffer registration.
How was the outcome achieved?
TestBed infrastructure was encountering a hang. As such, I added a simple routine that creates 8 process through fork(), and calls allReduce/allGather.
Additional Documentation:
What else should the reviewer know?
Approval Checklist
Do not approve until these items are satisfied.