CMakeLists.txt update to remove unnecessary variable #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrawther
approved these changes
Feb 20, 2024
LakshmiKumar23
requested changes
Feb 27, 2024
| option(BUILD_PYPACKAGE "Build rocAL Python Package" ON) | ||
| option(BUILD_WITH_AMD_ADVANCE "Build rocAL for advanced AMD GPU Architecture" OFF) | ||
| option(PYTHONVERSION "Python version to build rocal" "") | ||
| option(BUILD_WITH_AMD_ADVANCE "Build rocAL with Advanced GPU support" OFF) |
There was a problem hiding this comment.
@hansely why was pythonversion removed? Seems like you have not synced with ToT.
| find_package(Python3 QUIET COMPONENTS Interpreter Development) | ||
| endif() | ||
| find_package(pybind11 QUIET CONFIG) | ||
| set(Python3_FIND_VIRTUALENV FIRST) |
There was a problem hiding this comment.
@hansely Please undo these changes and sync to ToT
| @@ -280,8 +276,8 @@ if(${BUILD_ROCAL_PYBIND}) | |||
| add_dependencies(PyPackageInstall PyPackageBuild) | |||
|
|
|||
| #install rocAL pybind libs | |||
| install(FILES ${CMAKE_BINARY_DIR}/${TARGET_NAME}/${CMAKE_INSTALL_LIBDIR}/${TARGET_PYMODULE_NAME} DESTINATION ${CMAKE_INSTALL_PREFIX_PYTHON}) | |||
| install(FILES ${CMAKE_BINARY_DIR}/${TARGET_NAME}/${CMAKE_INSTALL_LIBDIR}/${TARGET_PYMODULE_NAME} DESTINATION ${CMAKE_INSTALL_PREFIX_PYTHON} COMPONENT runtime) | |||
There was a problem hiding this comment.
@hansely did you test this on pytorch dockers?
|
Closing this PR and reopening with develop branch synced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary variable : MIVisionX_LIBRARIES_DIRS
Update rocAL CMake to exclude rocAL_pybind subdirectory if manually turned off