Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocDecode integration in rocAL #253

Merged
merged 69 commits into from
Feb 5, 2025
Merged

rocDecode integration in rocAL #253

merged 69 commits into from
Feb 5, 2025

Conversation

fiona-gladwin
Copy link
Contributor

  • Add support for rocDecode hardware decoder in rocAL
  • Add support to create sequences using the seek operation in rocDecode, works seamlessly for H265 videos.

fiona-gladwin and others added 30 commits May 8, 2024 02:52
@fiona-gladwin
Add CMakeList changes
b902adf 
Requires VideoDemuxer to have .cpp file
@fiona-gladwin
Add rocDecode utils files and cmake changes
4b928e7
@rrawther
rocDecode integration for rocAL
ad1161a
@rrawther
Merge remote-tracking branch 'upstream/develop' into rr/rocdec_integr…
bcc6f5c 
…ation
@rrawther
merge with tot
0fcb28d
@fiona-gladwin
Add initial support for rocDecode integration
342d9ac
@fiona-gladwin
Add fix to decode sequences
d26c18c
@fiona-gladwin
VideoDemuxer - support to return dts
bfd1ad9
@fiona-gladwin
Support to seek exact frame
6873f6c 
Facing seg fault
@fiona-gladwin
Add intermediary buffers to copy
d89d3d9
@fiona-gladwin
Change the name of rocdec files
2e22877
@fiona-gladwin
Merge branch 'rocdecode_integrate_1' into rr/rocdec_integration
4bbc597
@fiona-gladwin
Temporary rocDecode cmake changes
21b0538 
Add utils folder to rocAL hip to compile with rocDecode
@fiona-gladwin
Fix CMake for rocDecode
e343af0
@fiona-gladwin
Minor fix
9223116
@fiona-gladwin
Fix stride for rocdecode video decoder
526d170
@fiona-gladwin
Revert "Temporary rocDecode cmake changes"
b0a7b01 
This reverts commit 21b0538.
@fiona-gladwin
Introduce CMake for rocDecode
494839e 
Revert additional changes
@fiona-gladwin
Fix issues with CMake
1752acf
@fiona-gladwin
rocDecode Flush decoder after decoding each sequence
c03169a
@fiona-gladwin
Merge branch 'develop' of https://github.com/ROCm/rocAL into fg/rocde…
7a09b51 
…c_integration
@fiona-gladwin
Add changes to flush decoder after seek
77041e3
@fiona-gladwin
Add support in rocDecode to seek to exact frame using dts
a937981
@fiona-gladwin
Add changes in API to pass device ID to video decoder
feed1c6
@fiona-gladwin
Merge branch 'develop' of https://github.com/ROCm/rocAL into fg/rocde…
b5d4a4c 
…c_integration
@fiona-gladwin
Add stream synchronize
a6f9c04
@fiona-gladwin
Merge branch 'develop' of https://github.com/ROCm/rocAL into fg/rocde…
3ef5613 
…c_integration
@fiona-gladwin
Merge branch 'develop' of https://github.com/ROCm/rocAL into fg/rocde…
8e04589 
…c_integration
@fiona-gladwin
Minor changes
97b5a03
@fiona-gladwin
Minor change
0370b4d
rrawther
rrawther requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve all review comments

rrawther
rrawther previously approved these changes Jan 30, 2025
View reviewed changes
@fiona-gladwin
Copy link
Contributor Author

fiona-gladwin commented Jan 30, 2025 •
edited
Loading

Please resolve all review comments

@rrawther and @LakshmiKumar23 Resolved all review comments

@LakshmiKumar23
Copy link
Contributor

Nothing to review for docs.

However, these seem to be a lot of changes. Do any of them need to be tracked in the changelog or the documentation?

@spolifroni-amd yes you are right
@fiona-gladwin please add a CHANGELOG. This is a big addition. Also needs to be added in docs

rrawther
rrawther requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog and doc for this

@fiona-gladwin
Copy link
Contributor Author

Please add changelog and doc for this

Done

LakshmiKumar23
LakshmiKumar23 previously approved these changes Jan 30, 2025
View reviewed changes
rrawther
rrawther previously approved these changes Jan 31, 2025
View reviewed changes
@rrawther
Copy link
Contributor

rrawther commented Feb 3, 2025

@kiritigowda : Not sure why the CI is failing in this. I would like to merge this PR

@kiritigowda
Copy link
Collaborator

@fiona-gladwin - the main readme requires updates to the prerequisites and update the version of the rocAL (2.2.0 to 2.3.0)

@fiona-gladwin fiona-gladwin dismissed stale reviews from rrawther and LakshmiKumar23 via 1e5f7b7 February 4, 2025 13:51
@fiona-gladwin
Copy link
Contributor Author

@fiona-gladwin - the main readme requires updates to the prerequisites and update the version of the rocAL (2.2.0 to 2.3.0)

Done, Please check

@rrawther
Copy link
Contributor

rrawther commented Feb 4, 2025

@kiritigowda please check and merge this PR

@kiritigowda kiritigowda merged commit 7ac767e into ROCm:develop Feb 5, 2025
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrawther rrawther rrawther approved these changes

@LakshmiKumar23 LakshmiKumar23 LakshmiKumar23 left review comments

@kiritigowda kiritigowda Awaiting requested review from kiritigowda kiritigowda is a code owner

@spolifroni-amd spolifroni-amd Awaiting requested review from spolifroni-amd

Assignees

@kiritigowda kiritigowda

Labels
ci:precheckin enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fiona-gladwin @kiritigowda @LakshmiKumar23 @rrawther @spolifroni-amd @SundarRajan28