rocAL C++ test suite fix #267
Open
+194
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fiona-gladwin
commented
Jan 21, 2025
fiona-gladwin
commented
- Fix issues with parsing arguments in C++ tests.
- Fix CMakeLists for basic_tests_gpu to invoke the correct backend.
- Fix issues with loop is set to true in rocAL - add changes for all readers.
- Fix warnings and issues in audio tests, img aug app, dataloader
This reverts commit eecec65.
Add return statement
fiona-gladwin
requested review from
kiritigowda,
rrawther and
a team
as code owners
rrawther
reviewed
Jan 24, 2025
rrawther
requested changes
Jan 24, 2025
| @@ -41,6 +41,8 @@ Caffe2LMDBRecordReader::Caffe2LMDBRecordReader() { | |||
|
|
|||
| unsigned Caffe2LMDBRecordReader::count_items() { | |||
There was a problem hiding this comment.
if count_items is a common function in all readers, please move it to base class
There was a problem hiding this comment.
The variable like _read_counter is private to the Caffe2 reader class, and not common in the Reader class
Should we move that to common as well?
There was a problem hiding this comment.
I see that the read_counter is common in all the readers same as count_items(). Please move both to base class and remove redefinitions in all the derived classes
rrawther
reviewed
Jan 27, 2025
| _processing = false; | ||
| _ring_buffer.release_all_blocked_calls(); | ||
| release(); | ||
| THROW("Exception thrown in the process routine: " + STR(e.what()) + STR("\n")); |
There was a problem hiding this comment.
Instead of raising exception here, in the run function, we need to check if the processing was succes or not. Then return appropriate error code from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.