-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocAL - External source reader #83
Merged
kiritigowda
merged 80 commits into
ROCm:develop
from
SundarRajan98:external_source_reader
Jan 16, 2024
Merged
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
755eb52
tensor changes
LakshmiKumar23 9caa64c
Update Doxyfile
LakshmiKumar23 6fa17b3
test updates
LakshmiKumar23 f128ab9
bug fixes
LakshmiKumar23 215fb90
bug fix
LakshmiKumar23 d65b188
adding image augemntation app changes
LakshmiKumar23 40a6ae2
Minor changes
fgladwin 660ccd9
Add ROI structure
fgladwin 11d2cd6
Add support to update multi dimension ROI
fgladwin d5a74be
Fix build issues wrt ROI struct
fgladwin 93271f4
Merge branch 'develop' into lk/tensor
LakshmiKumar23 0b6fc58
Merge branch 'develop-tensor' into fg/tensor_generic_roi
SundarRajan98 8475948
Merge branch 'lk/tensor' of https://github.com/LakshmiKumar23/rocAL i…
fgladwin efb3f45
Merge branch 'fg/tensor_generic_roi' of https://github.com/fgladwin/r…
fgladwin 223cdec
Merge branch 'fg/tensor_generic_roi' of https://github.com/fgladwin/r…
fgladwin 0a2b646
Merge branch 'develop' of https://github.com/ROCmSoftwarePlatform/roc…
fgladwin 1ac0258
Merge branch 'fg/tensor_roi' into fg/tensor_generic_roi
fgladwin f9d5fa6
Minor change
fgladwin 987ddbc
Merge branch 'fg/tensor' into fg/tensor_generic_roi
fgladwin 971f614
Remove redundant code
fgladwin 0985898
Minor change
fgladwin 3a04a02
Minor changes
fgladwin bdb0443
Modify struct names
fgladwin 52de343
Adding external source reader support to rocAL
SundarRajan98 b290600
ROCm Path - Options added (#73)
kiritigowda 75af629
Remove strides in ROI
fgladwin daf4913
Change shape to end for ROICords
fgladwin 30390bc
Fix crop dims in ssd random crop
fgladwin 8a825bc
Change ROI type to const in node.h
fgladwin a771f65
set mem handle with label buffer
SundarRajan28 5fc4b2d
change casting to c++ style
SundarRajan28 12609ea
Merge Roi tensor branch
SundarRajan28 3776f92
Address review comments
SundarRajan28 d5d8131
Remove external source label reader
fgladwin 0152f62
Minor changes
fgladwin e29d021
Remove labels bool in loaders
fgladwin 14e6ba3
Minor changes
fgladwin 5ffeec8
Revert storage_type to type
fgladwin de54706
Minor changes
fgladwin 0fe4b97
Minor changes
fgladwin 2fb286e
Combine all the test modes in pytorch.py
fgladwin 4ef9010
Adding external source support to generic iterator
SundarRajan98 3828a5a
Adding readme for external source python examples
SundarRajan98 a8f5d7b
Merge remote-tracking branch 'origin/develop' into external_source_re…
SundarRajan98 ac66905
CMake Find - Half (#76)
kiritigowda 8320904
Change copyright year
SundarRajan98 d1fc5fc
Resolving review comments
SundarRajan98 e586baf
Prerequisites - Boost Removal (#71)
hansely f1cb0d5
Merge remote-tracking branch 'ToT/develop' into external_source_reader
SundarRajan98 ad11859
Multiple Inheritance in External Source Reader
swetha097 ce02683
Add the commit the pass the ROI as xywh structure
swetha097 f45b74e
Increase the pqd
swetha097 2c4469a
Put all the examples in a single file
swetha097 99aa77f
Make minor changes from commit
SundarRajan28 eaf1052
Merge branch 'external_source_reader' of https://github.com/SundarRaj…
swetha097 0fc09f6
Del remaining examples
swetha097 56e3a30
Add changes for ROI
swetha097 5bfe974
Remove the rocAL external source folder
SundarRajan28 0c89a7b
Change the ROI struct of vectors to a vector of ROI structs and chang…
swetha097 04b4bdb
Add NONE to Mode and Resize the size of the ROIxywh vector in cpp uni…
swetha097 b04dce9
Merge branch 'external_source_reader_check' into external_source_reader
a986ccb
Remove the print statment
e2838a5
Pass the vectors as reference
swetha097 ea1f247
Move the ExternalSourceMode to the right
swetha097 c30e56e
Add const to pass vectors by reference and add one to one mapping in …
swetha097 61890cd
Some changes in the example file
swetha097 e75c44c
Changes in example file
swetha097 fda81a2
Minor changes in the test suite
swetha097 9cf3bb1
Remove nchw_to_nhwc conversions
swetha097 2d74fdc
Merge branch 'master' into external_source_reader
swetha097 80cace6
Merge branch 'develop' into external_source_reader
swetha097 aece203
Fix warnings
SundarRajan28 5087e33
Merge branch 'external_source_reader' of https://github.com/SundarRaj…
2d377ce
Bracket Spacing
SundarRajan28 7320123
Merge remote-tracking branch 'ToT/develop' into external_source_reader
SundarRajan98 4ce813d
Removing boost includes and updating python example
SundarRajan98 dbdca7e
Resolving review comments
SundarRajan98 558911b
Readme updates for external source tests
SundarRajan98 4c0f40d
Adding API changes for external source and set_mem_handle
SundarRajan98 0edcc74
Reording the pybind for ROIxywh struct
SundarRajan98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
################################################################################ | ||
# | ||
# MIT License | ||
# | ||
# Copyright (c) 2023 Advanced Micro Devices, Inc. | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included in all | ||
# copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
# | ||
################################################################################ | ||
find_path(HALF_INCLUDE_DIRS | ||
NAMES half/half.hpp | ||
HINTS | ||
$ENV{HALF_DIR}/include | ||
$ENV{ROCM_PATH}/include | ||
PATHS | ||
${HALF_DIR}/include | ||
/usr/include | ||
/usr/local/include | ||
${ROCM_PATH}/include | ||
) | ||
mark_as_advanced(HALF_INCLUDE_DIRS) | ||
|
||
if(HALF_INCLUDE_DIRS) | ||
set(HALF_FOUND TRUE) | ||
endif( ) | ||
|
||
include( FindPackageHandleStandardArgs ) | ||
find_package_handle_standard_args( HALF | ||
FOUND_VAR HALF_FOUND | ||
REQUIRED_VARS | ||
HALF_INCLUDE_DIRS | ||
) | ||
|
||
set(HALF_FOUND ${HALF_FOUND} CACHE INTERNAL "") | ||
set(HALF_INCLUDE_DIRS ${HALF_INCLUDE_DIRS} CACHE INTERNAL "") | ||
|
||
if(HALF_FOUND) | ||
message("-- ${White}Using HALF -- \n\tIncludes:${HALF_INCLUDE_DIRS}${ColourReset}") | ||
else() | ||
if(HALF_FIND_REQUIRED) | ||
message(FATAL_ERROR "{Red}FindHALF -- NOT FOUND${ColourReset}") | ||
endif() | ||
message( "-- ${Yellow}NOTE: FindHALF failed to find -- half.hpp${ColourReset}" ) | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
################################################################################ | ||
# | ||
# MIT License | ||
# | ||
# Copyright (c) 2023 Advanced Micro Devices, Inc. | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included in all | ||
# copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
# | ||
################################################################################ | ||
include(CheckCXXSourceCompiles) | ||
include(CMakePushCheckState) | ||
|
||
cmake_push_check_state(RESET) | ||
|
||
set(CMAKE_REQUIRED_FLAGS "-std=c++17") | ||
|
||
check_cxx_source_compiles(" | ||
#include <filesystem> | ||
int main() { | ||
std::filesystem::path p; | ||
return 0; | ||
} | ||
" STD_FILESYSTEM_PRESENT) | ||
|
||
cmake_pop_check_state() | ||
|
||
if(NOT STD_FILESYSTEM_PRESENT) | ||
cmake_push_check_state(RESET) | ||
set(CMAKE_REQUIRED_FLAGS "-std=c++17") | ||
|
||
check_cxx_source_compiles(" | ||
#include <experimental/filesystem> | ||
int main() { | ||
std::experimental::filesystem::path p; | ||
return 0; | ||
} | ||
" EXPERIMENTAL_FILESYSTEM_PRESENT) | ||
|
||
cmake_pop_check_state() | ||
endif() | ||
|
||
set(FILESYSTEM_FOUND TRUE) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not needed anymore.
@kiritigowda: can you confirm