Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand Omniperf to ROCm Compute Profiler to ROCm 6.3 branch #468

Open
wants to merge 35 commits into
base: release/rocm-rel-6.3
Choose a base branch
from

Commits on Sep 25, 2024

  1. Check Python version on application launch (#393)

    * Check that the minimum required Python (3.8) version is used.
    
    Prints a descriptive error message, rather than a cryptic import
    failure, if minimum Python version is not met.
    
    Internal ticket SWDEV-477233.
    
    
    * Disable the RPM mangling of shebangs.
    
    The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`.
    With this set, omniperf is always using the platform installed version
    of python, which is python 3.6 on RHEL 8. Using virtual environments,
    like conda, did not work.
    
    * Fix pylint issues
    
    ---------
    
    Signed-off-by: David Galiffi <[email protected]>
    dgaliffiAMD authored and coleramos425 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    75a4b51 View commit details
    Browse the repository at this point in the history
  2. Remove dev and main branch from workflows. (#404)

    * Remove `dev` and `main` branch from workflows.
    
    Update links in documentation.
    
    Signed-off-by: David Galiffi <[email protected]>
    
    * `amd-staging` -> `amd-mainline` in docs
    
    Signed-off-by: Peter Jun Park <[email protected]>
    
    ---------
    
    Signed-off-by: David Galiffi <[email protected]>
    Signed-off-by: Peter Jun Park <[email protected]>
    Co-authored-by: Peter Jun Park <[email protected]>
    2 people authored and coleramos425 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    68e5db2 View commit details
    Browse the repository at this point in the history
  3. Update dependabot.yml target-branch

    Signed-off-by: David Galiffi <[email protected]>
    dgaliffiAMD authored and coleramos425 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ae6ed4c View commit details
    Browse the repository at this point in the history
  4. Run Workflows on Release Branches (#409)

    Signed-off-by: David Galiffi <[email protected]>
    dgaliffiAMD authored and coleramos425 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3499b85 View commit details
    Browse the repository at this point in the history
  5. mv changes to changelog.md

    Signed-off-by: Peter Jun Park <[email protected]>
    peterjunpark authored and coleramos425 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    92cfd51 View commit details
    Browse the repository at this point in the history
  6. Add omniperf suffix to MOD_INSTALL_PATH in docs (#414)

    If we don't add the suffix omniperf to the install path then the subsequent instruction of module load omniperf will not work
    
    Signed-off-by: coleramos425 <[email protected]>
    coleramos425 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    68e2cf0 View commit details
    Browse the repository at this point in the history
  7. Rollback Grafana version in Docker container to enable deprecated Ang…

    …ular plugin (#416)
    
    Signed-off-by: coleramos425 <[email protected]>
    coleramos425 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2aee85c View commit details
    Browse the repository at this point in the history
  8. Fix typo and CHANGELOG modification

    After meeting with the DevOps team, I've added the Unreleased keyword to new CHANGELOG section per their request
    
    Signed-off-by: coleramos425 <[email protected]>
    coleramos425 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bc4d386 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ecd69d1 View commit details
    Browse the repository at this point in the history
  10. External CI: enable CI triggers (#426)

    Signed-off-by: Daniel Su <[email protected]>
    danielsu-amd authored and coleramos425 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7ff385a View commit details
    Browse the repository at this point in the history
  11. Add the ability to determine GPU model from Chip ID (#423)

    * Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary.
    
    Signed-off-by: xuchen-amd <[email protected]>
    
    * Add support for MI300X_A1
    
    Signed-off-by: xuchen-amd <[email protected]>
    
    * Remove MI308X identification using num CUs, and format Python using black.
    
    Signed-off-by: xuchen-amd <[email protected]>
    
    * Add Read the Docs
    
    Signed-off-by: xuchen-amd <[email protected]>
    
    * Add sphinx requirement
    
    Signed-off-by: xuchen-amd <[email protected]>
    
    * Remove gpu_model identification using gpu_arch
    
    Signed-off-by: xuchen-amd <[email protected]>
    
    * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id.
    
    Signed-off-by: xuchen-amd <[email protected]>
    
    * Fix Python formatting using black.
    
    Signed-off-by: xuchen-amd <[email protected]>
    
    ---------
    
    Signed-off-by: xuchen-amd <[email protected]>
    xuchen-amd authored and coleramos425 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c48e6e3 View commit details
    Browse the repository at this point in the history
  12. Tarball on rocm tags and MAINTAINERS guide (#402)

    * Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure
    
    Signed-off-by: coleramos425 <[email protected]>
    
    * Apply linting feedback
    
    Signed-off-by: coleramos425 <[email protected]>
    
    * Update links in MAINTAINERS for new branches
    
    Signed-off-by: coleramos425 <[email protected]>
    
    * Update MAINTAINERS.md for changelog formatting
    
    Signed-off-by: coleramos425 <[email protected]>
    
    * Update Omniperf ver checker to allow tags with rocm- prefix
    
    Signed-off-by: coleramos425 <[email protected]>
    
    * Add step to packaging workflow to upload release tarball to release
    
    Signed-off-by: coleramos425 <[email protected]>
    
    * Synax change for release name in packaging action
    
    Signed-off-by: coleramos425 <[email protected]>
    
    * Update MAINTAINERS for instuctions on ROCm releases
    
    Signed-off-by: coleramos425 <[email protected]>
    
    * Update softprops pluvin to v2 and remove release name
    
    Removing the release name enables us to modify an existing release with the matching tag
    
    Signed-off-by: coleramos425 <[email protected]>
    
    * Remove draft option on softprops plugin
    
    Signed-off-by: coleramos425 <[email protected]>
    
    ---------
    
    Signed-off-by: coleramos425 <[email protected]>
    coleramos425 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0d15023 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    ba4429d View commit details
    Browse the repository at this point in the history
  2. Remove unrelease prefix from CHANGELOG

    Signed-off-by: coleramos425 <[email protected]>
    coleramos425 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5d7af74 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Update issue template

    Signed-off-by: coleramos425 <[email protected]>
    coleramos425 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    faaf5bd View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Add smart name and notes to triggered releases (#438)

    Signed-off-by: coleramos425 <[email protected]>
    coleramos425 authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c8a1add View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Skip output lines that have UTF8 decoding error (#441)

    * Avoid crash if non-UTF8 character is encountered in output
    
    Signed-off-by: benrichard-amd <[email protected]>
    
    * Ignore lines with non-UTF-8 characters. Do not print error.
    
    Signed-off-by: benrichard-amd <[email protected]>
    
    * Remove trailing whitespace
    
    Signed-off-by: benrichard-amd <[email protected]>
    
    ---------
    
    Signed-off-by: benrichard-amd <[email protected]>
    benrichard-amd authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    fb210ab View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Documented Docker container OpenSSL abilities being affected by Host …

    …network proxy services (#440)
    
    * Documented Docker container OpenSSL abilities being affected by host
    network proxy services, causing network certificates verification
    problem during Docker container build stage of Grafana server setup.
    
    Signed-off-by: Vladimir Stempen <[email protected]>
    
    * Update docs/install/grafana-setup.rst
    
    Co-authored-by: Peter Park <[email protected]>
    Signed-off-by: vstempen <[email protected]>
    
    ---------
    
    Signed-off-by: Vladimir Stempen <[email protected]>
    Signed-off-by: vstempen <[email protected]>
    Co-authored-by: Peter Park <[email protected]>
    vstempen and peterjunpark authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ba94cb8 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Update CODEOWNERS for product team

    Signed-off-by: coleramos425 <[email protected]>
    coleramos425 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e633d17 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Use MI300 chip_id instead of model to detect XCD count (#448)

    In a previous change we started using "MI300" for gpu_model instead of the full
    "MI300X_A0" or "MI300X_A1", etc.
    
    The XCD detection code was using gpu_model and expecting the full name, causing
    the XCD count = 1. Passing chip_id fixes the issue.
    
    Signed-off-by: benrichard-amd <[email protected]>
    benrichard-amd authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a236fe0 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Change argparser help from '--list-kernels' (deprecated) to '--list-s…

    …tats'. (#449)
    
    Signed-off-by: OReilly, Ossian <[email protected]>
    ooreilly authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5f3c0f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Enable baseline comparison between workloads from the same path (#447)

    * Enable baseline comparison between workloads from the same path
    
    Signed-off-by: zichguan-amd <[email protected]>
    
    * Formatting
    
    Signed-off-by: zichguan-amd <[email protected]>
    
    * Change test to verify baseline works with same path
    
    Signed-off-by: zichguan-amd <[email protected]>
    
    * Add three-way comparison test case
    
    Signed-off-by: zichguan-amd <[email protected]>
    
    ---------
    
    Signed-off-by: zichguan-amd <[email protected]>
    zichguan-amd authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    13a06f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Add broken mclk workaround for all arch (#453)

    * Check for missing mclk, use hard-coded values if needed
    
    Signed-off-by: benrichard-amd <[email protected]>
    
    * Fix typo
    
    Signed-off-by: benrichard-amd <[email protected]>
    
    ---------
    
    Signed-off-by: benrichard-amd <[email protected]>
    benrichard-amd authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2de2faf View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Rename Omniperf to ROCm Compute Profiler (#428)

    - Update filenames.
    - Update executable to `rocprof-compute` 
    - Update update package to `rocprofiler-compute`
    - Update name in application output and logs
    - Update name in README files
    - Update testing and workflows
    
    ---------
    
    Signed-off-by: Xuan Chen <[email protected]>
    xuchen-amd authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    31b4de1 View commit details
    Browse the repository at this point in the history
  2. Give executable permission to rocprof-compute (#456)

    Signed-off-by: coleramos425 <[email protected]>
    coleramos425 authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    8a88e8b View commit details
    Browse the repository at this point in the history
  3. Update VERSION to 3.0.0 (#457)

    * Update VERSION  and README to 3.0.0
    * Update version mismatch of profiling data to a warning.
    
    Signed-off-by: David Galiffi <[email protected]>
    dgaliffiAMD authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    152eff0 View commit details
    Browse the repository at this point in the history
  4. Install LICENCE to ${CMAKE_INSTALL_DOCDIR} (#458)

    * Install LICENSE to ${CMAKE_INSTALL_DOCDIR}
    * Update tarball.yml to test for LICENSE file after the install
    
    ---------
    
    Signed-off-by: David Galiffi <[email protected]>
    dgaliffiAMD authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    50755de View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. fix PoP of VALU Active Threads with wave_size

    Signed-off-by: fei.zheng <[email protected]>
    feizheng10 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1b37572 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Fix changelog heading

    Signed-off-by: Peter Park <[email protected]>
    peterjunpark committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    6a381d8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #460 from feizheng10/doc_warp_efficency

    Fix PoP of VALU Active Threads with wave_size
    feizheng10 authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b4f9b38 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7821707 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    6c57dfc View commit details
    Browse the repository at this point in the history
  2. Update branding in documentation (#442)

    * find/replace Omniperf to ROCm Compute Profiler
    
    Signed-off-by: Peter Park <[email protected]>
    
    * update name in Sphinx conf
    
    Signed-off-by: Peter Park <[email protected]>
    
    * mv what-is-omniperf.rst -> what-is-rocprof-compute.rst
    
    Signed-off-by: Peter Park <[email protected]>
    
    * update Tutorials section
    
    Signed-off-by: Peter Park <[email protected]>
    
    * add Omniperf as keyword to Conceptual section for internal search
    
    Signed-off-by: Peter Park <[email protected]>
    
    * update Reference section
    
    Signed-off-by: Peter Park <[email protected]>
    
    * black fmt conf.py
    
    Signed-off-by: Peter Park <[email protected]>
    
    * update profile mode and basic usage subsections
    
    Signed-off-by: Peter Park <[email protected]>
    
    * update how to use analyze mode subsection
    
    Signed-off-by: Peter Park <[email protected]>
    
    * update install section
    
    Signed-off-by: Peter Park <[email protected]>
    
    * fix sphinx warnings
    
    Signed-off-by: Peter Park <[email protected]>
    
    * fix cmd line examples in profile/mode.rst
    
    Signed-off-by: Peter Park <[email protected]>
    
    * update install decision tree image
    
    Signed-off-by: Peter Park <[email protected]>
    
    * fix TOC and index
    
    Signed-off-by: Peter Park <[email protected]>
    
    fix weird wording
    
    * fix cli text: deriving rocprofiler-compute metrics...
    
    Signed-off-by: Peter Park <[email protected]>
    
    * update standalone-gui.rst
    
    Signed-off-by: Peter Park <[email protected]>
    
    * restore removed doc updates from #428
    
    Signed-off-by: Peter Park <[email protected]>
    
    * update ref to Omniperf in index.rst
    
    Signed-off-by: Peter Park <[email protected]>
    
    * fix grafana connection name to match image
    
    Signed-off-by: Peter Park <[email protected]>
    
    * update cmds in tutorials
    
    Signed-off-by: Peter Park <[email protected]>
    
    ---------
    
    Signed-off-by: Peter Park <[email protected]>
    peterjunpark authored and dgaliffiAMD committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a9019f1 View commit details
    Browse the repository at this point in the history
  3. Update webui branding (#459)

    * Update name and icon for browser tab to rocprofiler-compute.
    
    Signed-off-by: xuchen-amd <[email protected]>
    
    * Update name and icon for browser tab to rocprofiler-compute.
    
    Signed-off-by: xuchen-amd <[email protected]>
    
    ---------
    
    Signed-off-by: xuchen-amd <[email protected]>
    xuchen-amd authored and dgaliffiAMD committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7d8064f View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Configuration menu
    Copy the full SHA
    614ed56 View commit details
    Browse the repository at this point in the history