Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebranding name change patch #469

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Rebranding name change patch #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4660dc
Patch in missed name change for rebranding.
xuchen-amd Nov 6, 2024
0cf06d3
Patch in missed name change for rebranding.
xuchen-amd Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/mi-rhel9.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
runs-on: [mi100, rhel9]

env:
PYTHONPATH: /home1/ciuser/omniperf_deps
PYTHONPATH: /home1/ciuser/rocprofiler-compute_deps
CI_VISIBLE_DEVICES: 1
name: ROCm v${{ matrix.version }} / ${{ matrix.hardware }} / ${{ matrix.profiler }}
steps:
Expand Down
0 grafana/dashboards/Omniperf_v1.0.3_pub.json → ...dashboards/RocProfCompute_v1.0.3_pub.json
View file
Open in desktop
File renamed without changes.
0 grafana/dashboards/Omniperf_v1.0.5_pub.json → ...dashboards/RocProfCompute_v1.0.5_pub.json
View file
Open in desktop
File renamed without changes.
0 grafana/dashboards/Omniperf_v1.0.7_pub.json → ...dashboards/RocProfCompute_v1.0.7_pub.json
View file
Open in desktop
File renamed without changes.
0 grafana/dashboards/Omniperf_v1.0.8_pub.json → ...dashboards/RocProfCompute_v1.0.8_pub.json
View file
Open in desktop
File renamed without changes.
0 grafana/dashboards/Omniperf_v2.0.0_pub.json → ...dashboards/RocProfCompute_v2.0.0_pub.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/rocprof-compute
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def verify_deps():


def main():
"""Main function for omniperf"""
'''Main function for rocprofiler-compute'''

# verify required python dependencies
verify_deps()
Expand Down
2 changes: 1 addition & 1 deletion tests/generate_workloads.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ declare -A commands=(
[mem_levels_vL1d_LDS]='--roof-only --mem-level vL1D LDS'
[mem_levels_L2_vL1d_LDS]='--roof-only --mem-level L2 vL1D LDS'
#########################################################
# Attempt to break omniperf #
# Attempt to break rocprofiler-compute #
#########################################################
[dispatch_7]='--dispatch 7'
[dispatch_6_8]='--dispatch 6:8'
Expand Down
4 changes: 2 additions & 2 deletions tests/test_analyze_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,7 +1134,7 @@ def test_baseline():
with patch(
"sys.argv",
[
"omniperf",
"rocprof-compute",
"analyze",
"--path",
"tests/workloads/vcopy/MI200",
Expand All @@ -1149,7 +1149,7 @@ def test_baseline():
with patch(
"sys.argv",
[
"omniperf",
"rocprof-compute",
"analyze",
"--path",
"tests/workloads/vcopy/MI100",
Expand Down
8 changes: 4 additions & 4 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def setup_workload_dir(input_dir, suffix="_tmp", clean_existing=True):


def clean_output_dir(cleanup, output_dir):
"""Remove output directory generated from omniperf execution
"""Remove output directory generated from rocprofiler-compute execution

Args:
cleanup (boolean): flag to enable/disable directory cleanup
Expand Down Expand Up @@ -127,12 +127,12 @@ def check_csv_files(output_dir, num_devices, num_kernels):
return file_dict


def launch_omniperf(config, options, workload_dir, check_success=True):
"""Launch Omniperf with command-line optoins
def launch_rocprof_compute(config, options, workload_dir, check_success=True):
"""Launch ROCm Compute Profiler with command-line optoins

Args:
config (list): runtime configuration settings
options (list): command line options to provide to omniperf
options (list): command line options to provide to rocprofiler-compute
workload_dir (string): desired output directory
check_success (bool, optional): Whether to verify successful exit condition. Defaults to True.

Expand Down
Loading