Changes for spack #2578
Merged
Changes for spack #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afzpatel
commented
Jul 8, 2024
afzpatel
commented
- Add some rocm libs to the rpath so they link when running with spack built rocm binaries
- Add conditions to check if HIP_DEVICE_LIB_PATH and LLVM_PATH are set because the bitcode and LLVM bin directories are not contained in the ROCM_PATH when using spack built ROCm
|
retest Ubuntu-GPU-single please |
hsharsha
approved these changes
Jul 10, 2024
|
retest Ubuntu-GPU-single please |
i-chaochen
reviewed
Jul 11, 2024
|
there are some issues on |
i-chaochen
approved these changes
Jul 12, 2024
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Aug 5, 2024
Imported from GitHub PR openxla/xla#14854 Thanks @afzpatel for this work and this changes is for spack using ROCm libraries from ROCm/tensorflow-upstream#2578 @xla-rotation Copybara import of the project: -- 588be97790756155b507ac840ef3c15ddf61c683 by Chao Chen <[email protected]>: changes for spack by afzpatel Merging this change closes #14854 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14854 from ROCm:ci_spack_change 588be97790756155b507ac840ef3c15ddf61c683 PiperOrigin-RevId: 659517988
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Aug 5, 2024
Imported from GitHub PR #14854 Thanks @afzpatel for this work and this changes is for spack using ROCm libraries from ROCm/tensorflow-upstream#2578 @xla-rotation Copybara import of the project: -- 588be97 by Chao Chen <[email protected]>: changes for spack by afzpatel Merging this change closes #14854 FUTURE_COPYBARA_INTEGRATE_REVIEW=#14854 from ROCm:ci_spack_change 588be97 PiperOrigin-RevId: 659517988
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 5, 2024
Imported from GitHub PR openxla/xla#14854 Thanks @afzpatel for this work and this changes is for spack using ROCm libraries from ROCm#2578 @xla-rotation Copybara import of the project: -- 588be97790756155b507ac840ef3c15ddf61c683 by Chao Chen <[email protected]>: changes for spack by afzpatel Merging this change closes #14854 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14854 from ROCm:ci_spack_change 588be97790756155b507ac840ef3c15ddf61c683 PiperOrigin-RevId: 659517988
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Aug 6, 2024
Imported from GitHub PR openxla/xla#14854 Thanks @afzpatel for this work and this changes is for spack using ROCm libraries from ROCm/tensorflow-upstream#2578 @xla-rotation Copybara import of the project: -- 588be97790756155b507ac840ef3c15ddf61c683 by Chao Chen <[email protected]>: changes for spack by afzpatel Merging this change closes #14854 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14854 from ROCm:ci_spack_change 588be97790756155b507ac840ef3c15ddf61c683 PiperOrigin-RevId: 659517988
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Aug 6, 2024
Imported from GitHub PR #14854 Thanks @afzpatel for this work and this changes is for spack using ROCm libraries from ROCm/tensorflow-upstream#2578 @xla-rotation Copybara import of the project: -- 588be97 by Chao Chen <[email protected]>: changes for spack by afzpatel Merging this change closes #14854 FUTURE_COPYBARA_INTEGRATE_REVIEW=#14854 from ROCm:ci_spack_change 588be97 PiperOrigin-RevId: 659517988
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 6, 2024
Imported from GitHub PR openxla/xla#14854 Thanks @afzpatel for this work and this changes is for spack using ROCm libraries from ROCm#2578 @xla-rotation Copybara import of the project: -- 588be97790756155b507ac840ef3c15ddf61c683 by Chao Chen <[email protected]>: changes for spack by afzpatel Merging this change closes #14854 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#14854 from ROCm:ci_spack_change 588be97790756155b507ac840ef3c15ddf61c683 PiperOrigin-RevId: 659517988
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Aug 6, 2024
Imported from GitHub PR openxla/xla#14854 Thanks @afzpatel for this work and this changes is for spack using ROCm libraries from ROCm/tensorflow-upstream#2578 @xla-rotation Copybara import of the project: -- 588be97790756155b507ac840ef3c15ddf61c683 by Chao Chen <[email protected]>: changes for spack by afzpatel Merging this change closes #14854 PiperOrigin-RevId: 659932164
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Aug 6, 2024
Imported from GitHub PR #14854 Thanks @afzpatel for this work and this changes is for spack using ROCm libraries from ROCm/tensorflow-upstream#2578 @xla-rotation Copybara import of the project: -- 588be97 by Chao Chen <[email protected]>: changes for spack by afzpatel Merging this change closes #14854 COPYBARA_INTEGRATE_REVIEW=#14854 from ROCm:ci_spack_change 588be97 PiperOrigin-RevId: 659932164
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 6, 2024
Imported from GitHub PR openxla/xla#14854 Thanks @afzpatel for this work and this changes is for spack using ROCm libraries from ROCm#2578 @xla-rotation Copybara import of the project: -- 588be97790756155b507ac840ef3c15ddf61c683 by Chao Chen <[email protected]>: changes for spack by afzpatel Merging this change closes #14854 PiperOrigin-RevId: 659932164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.