[tune_gemm] Update the filter for LDS usage for stream-pipelineV2 #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guacamoleo
requested changes
Nov 12, 2024
| LDSB = BLOCK_SIZE_K * BLOCK_SIZE_N * elemBytes_b | ||
| if num_stages <= 1: | ||
| # No pipeline, buffer A and buffer B can re-use each other | ||
| LDS = min(LDSA, LDSB) |
There was a problem hiding this comment.
I think we want max(LDSA, LDSB) to be able to store the larger.
|
I'd suggest to still consider num_stages=0 for now, change it to 2 and add a warning for deprecation, considering some ppl might still be using older version. |
We have a warning here to make sure user will change num_stages = 0 to 2: https://github.com/triton-lang/triton/blob/9d6736a501d0499348d48d192b6260338ca19da0/third_party/amd/backend/compiler.py#L219 |
guacamoleo
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.