Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Fixed linker issues related to fp8 buffer_comparator functions #57

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[ROCm] Fixed linker issues related to fp8 buffer_comparator functions #57

merged 1 commit into from
Nov 13, 2024

Conversation

zoranjovanovic-ns
Copy link

Fixed new compilation issue from SWDEV-476829

jayfurmanek
jayfurmanek approved these changes Nov 13, 2024
View reviewed changes
Copy link

@jayfurmanek jayfurmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer using a device query instead of a #if but this is good for the bug fix on 0.4.28

@jayfurmanek jayfurmanek merged commit 5e84cfd into rocm-jaxlib-v0.4.28-qa Nov 13, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayfurmanek jayfurmanek jayfurmanek approved these changes

@i-chaochen i-chaochen Awaiting requested review from i-chaochen

@pemeliya pemeliya Awaiting requested review from pemeliya

Assignees
No one assigned
Labels
kokoro:force-run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoranjovanovic-ns @jayfurmanek