[ROCm] implement hermetic rocm dependency #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekstheod
force-pushed
the
atheodor/implement_hermetic_rocm_dependency
branch
from
f743561
to
4377c1c
Compare
alekstheod
changed the title
alekstheod
requested review from
draganmladjenovic,
i-chaochen,
pemeliya and
hsharsha
alekstheod
changed the title
alekstheod
changed the base branch from
rocm-jaxlib-v0.4.30-qa
to
rocm-jaxlib-v0.4.31-qa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has as a goal to introduce an external dependency to the rocm library and tools.
Building xla with the hermetic rocm is done by using these env variables:
--repo_env=OS=ubuntu_20.04 --repo_env=ROCM_VERSION=6.2.0One has to provie OS version and ROCm version to initialize a proper rocm repository.
If these flags are not set then default ROCm installation will be used to build XLA.
Sample command:
bazel --output_base=./bazel-build-dir run --config=rocm //xla/... --repo_env=OS=ubuntu_20.04 --repo_env=ROCM_VERSION=6.2.0@xla-rotation could you review my PR please?