Make default ssh port configurable #466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XECDesign
reviewed
Nov 17, 2020
build.sh
Outdated
| @@ -172,6 +172,7 @@ export WPA_PASSWORD | |||
| export WPA_COUNTRY | |||
| export ENABLE_SSH="${ENABLE_SSH:-0}" | |||
| export PUBKEY_ONLY_SSH="${PUBKEY_ONLY_SSH:-0}" | |||
| export SSH_PORT="${SSH_PORT:-22}" | |||
There was a problem hiding this comment.
Since the default port is already 22, why fallback to setting this variable to 22? If you do this, the -n condition will not be true and you'll modify the default sshd_config even if there's no change necessary. Then users will be bugged about conffile changes any time sshd_config changes in the debian package.
There was a problem hiding this comment.
I'll change to export SSH_PORT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can change ssh port by setting
SSH_PORTin theconfigfileRelated issue: #282