Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templates with new datetimes param #81

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Padeanu
Copy link
Contributor

@Padeanu Padeanu commented Dec 5, 2024

No description provided.

Copy link
Contributor

@nleconte-csgroup nleconte-csgroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not modify anymore the configurations directly here, but rather go through the rs-server repository.
I don't see the modification in the rs-server in the develop branch nor any other branches.

For more info, check the ⚠️ BREAKING section of the changelog of this repository.

@Padeanu
Copy link
Contributor Author

Padeanu commented Dec 10, 2024

We should not modify anymore the configurations directly here, but rather go through the rs-server repository. I don't see the modification in the rs-server in the develop branch nor any other branches.

For more info, check the ⚠️ BREAKING section of the changelog of this repository.

@nleconte-csgroup RS-PYTHON/rs-server#745 This PR have a corresponding one in rs-server.

@nleconte-csgroup
Copy link
Contributor

We should not modify anymore the configurations directly here, but rather go through the rs-server repository. I don't see the modification in the rs-server in the develop branch nor any other branches.
For more info, check the ⚠️ BREAKING section of the changelog of this repository.

@nleconte-csgroup RS-PYTHON/rs-server#745 This PR have a corresponding one in rs-server.

Thank you, I searched 550 instead of 560 🤡

So as soon as RS-PYTHON/rs-server#745 is merged in rs-server, this one can be merged (otherwise we have incoherent configuration versions).

@nleconte-csgroup nleconte-csgroup self-requested a review December 10, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants