-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opentelemetry requests hook to trace HTTP headers #795
Conversation
de6b2d0
to
b9afb4a
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
b9afb4a
to
e7a0df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vprivat-ads do we need the same in rs-client-libraries ? Else I'm OK with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it only intended for local mode or should it be also applicable for the server mode (K8S) ? If so, we should modify the helm charts and the values in the infrastructure.
e7a0df6
to
e9bfea4
Compare
@jgaucher-cs no, I don't see a need on client side for now. It's very easy to update the code locally if needed, without having resort to OpenTelemetry. This change is useful in cluster mode to avoid having to build a new docker image. |
SonarQube Quality Gate Result
updated: 1/3/2025, 15:07:57 (UTC+0) |
e9bfea4
to
b9cbe2b
Compare
Quality Gate passedIssues Measures |
Optionally trace HTTP headers from requests/responses in OpenTelemetry.
Disabled by default (security), to enable it, define OTEL_PYTHON_REQUESTS_TRACE_HEADERS environment variable.