Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Janus RTP crash files. #5

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Add Janus RTP crash files. #5

merged 1 commit into from
Mar 7, 2019

Conversation

atoppi
Copy link
Contributor

@atoppi atoppi commented Mar 7, 2019

Add the files that crashed Janus while fuzzing the RTP parsers.

The RTP parsers that have been tested are:

  • vp8
  • vp9
  • h264

@ibc
Copy link
Contributor

ibc commented Mar 7, 2019

Are those files codec payloads? If so, may be they should be placed in #1?

@ibc
Copy link
Contributor

ibc commented Mar 7, 2019

I'm just thinking about whether the reports folder makes sense or not. I mean, I understand it's supposed to hold files that have generated a crash in an implementation. However, does the reports folder contain valid RTP, RTCP, STUN, or codec payload "packets"? If so, IMHO they should be placed in the corpora folder, am I wrong?

@atoppi
Copy link
Contributor Author

atoppi commented Mar 7, 2019

Hi Iñaki,
We have not implemented different fuzzing targets for specific codec payloads, we just let the fuzzer do its mutations on the corpus.

IMHO the reports folder should not contain valid packets by definition. If an implementation is crashing with a valid pattern, that is not something that should be shared on this repository but a simple bug in that specific implementation.

In other words, the report files in this PR do not contain valid payloads.

@atoppi
Copy link
Contributor Author

atoppi commented Mar 7, 2019

I mean, the sense of the reports folder is that if some developer did an error in the implementation and the fuzzer discovered a pattern that triggers that error, maybe some other developer may have done the same error and so the crash file will be useful to easily identify the bug.

@ibc
Copy link
Contributor

ibc commented Mar 7, 2019

Yeah, clear. Makes sense. I just (wrongly) understood that the files in this PR were valid RTP packets or codec payloads.

@ibc ibc merged commit 2e4c5a4 into RTC-Cartel:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants