Corrected a bad statement running Tcl_NewListObj() that fails to

assign the result to anything, causing later uses of variable "lobj" to have an unitialized value and potentially causing a crash condition. Thanks to Risto Bell for pointing out the error.
RTimothyEdwards · May 14, 2024 · 291ba96 · 291ba96
1 parent e4c28ef
commit 291ba96
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-8.3.482
+8.3.483
diff --git a/commands/CmdRS.c b/commands/CmdRS.c
@@ -2338,8 +2338,7 @@ CmdSetLabel(w, cmd)
 		if (locargc == 2)
 		{
 #ifdef MAGIC_WRAPPER
-	 	    Tcl_Obj *lobj;
-		    Tcl_NewListObj(0, NULL);
+		    lobj = Tcl_NewListObj(0, NULL);
 	    	    Tcl_ListObjAppendElement(magicinterp, lobj,
 				Tcl_NewIntObj(DefaultLabel->lab_offset.p_x));
 	    	    Tcl_ListObjAppendElement(magicinterp, lobj,