Skip to content

Commit

Permalink
Corrected an error in "ResolveAutomorphsByPin" where the code states
Browse files Browse the repository at this point in the history
to check that the nodes with matching names are pins, but never does.
This results in an attempt to resolve automorphs by matching pin
names AND net names.  However, net names can match without the nets
matching, as pointed out by Andrey Bondar (private communication).
Fixed simply by adding the specified check that the node being name-
matched is actually a pin.
  • Loading branch information
RTimothyEdwards committed Dec 27, 2024
1 parent 49c0de0 commit 2483b74
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.5.287
1.5.288
4 changes: 3 additions & 1 deletion base/netcmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -6604,7 +6604,9 @@ int ResolveAutomorphsByPin()
if (N1->hashval != orighash) continue;
for (N2 = N1->next; N2 != NULL; N2 = N2->next) {
if ((N2->graph != N1->graph) &&
(*matchfunc)(N2->object->name, N1->object->name)) {
(*matchfunc)(N2->object->name, N1->object->name) &&
(N1->object->type == PORT || N2->object->type == PORT)) {

if (Debug == TRUE)
Printf("Symmetry group broken by name match (pin %s)\n", N2->object->name);
Magic(newhash);
Expand Down

0 comments on commit 2483b74

Please sign in to comment.